Fix some clippy lints.

Author: sunfishcode

examples/stdio.rs

@@ -336,11 +336,11 @@ fn show<Fd: AsFd>(fd: Fd) -> io::Result<()> {
 #[cfg(not(windows))]
 fn key(b: u8) -> String {
     if b == 0 {
-        format!("<undef>")
+        "<undef>".to_string()
     } else if b < 0x20 {
         format!("^{}", (b + 0x40) as char)
     } else if b == 0x7f {
-        format!("^?")
+        "^?".to_string()
     } else {
         format!("{}", b as char)
     }

src/backend/libc/thread/syscalls.rs

@@ -12,6 +12,7 @@ use {
     super::super::conv::{borrowed_fd, ret_c_int, syscall_ret},
     crate::fd::BorrowedFd,
     crate::process::{Pid, RawNonZeroPid},
+    crate::utils::as_mut_ptr,
 };
 #[cfg(not(any(
     apple,
@@ -308,8 +309,13 @@ pub(crate) fn capget(
     header: &mut linux_raw_sys::general::__user_cap_header_struct,
     data: &mut [MaybeUninit<linux_raw_sys::general::__user_cap_data_struct>],
 ) -> io::Result<()> {
-    let header: *mut _ = header;
-    unsafe { syscall_ret(c::syscall(c::SYS_capget, header, data.as_mut_ptr())) }
+    unsafe {
+        syscall_ret(c::syscall(
+            c::SYS_capget,
+            as_mut_ptr(header),
+            data.as_mut_ptr(),
+        ))
+    }
 }
 
 #[cfg(linux_kernel)]
@@ -318,8 +324,7 @@ pub(crate) fn capset(
     header: &mut linux_raw_sys::general::__user_cap_header_struct,
     data: &[linux_raw_sys::general::__user_cap_data_struct],
 ) -> io::Result<()> {
-    let header: *mut _ = header;
-    unsafe { syscall_ret(c::syscall(c::SYS_capset, header, data.as_ptr())) }
+    unsafe { syscall_ret(c::syscall(c::SYS_capset, as_mut_ptr(header), data.as_ptr())) }
 }
 
 #[cfg(linux_kernel)]

src/backend/libc/time/syscalls.rs

@@ -277,7 +277,6 @@ pub(crate) fn clock_settime(id: ClockId, timespec: Timespec) -> io::Result<()> {
     any(target_arch = "arm", target_arch = "mips", target_arch = "x86"),
     target_env = "gnu",
 ))]
-#[must_use]
 unsafe fn clock_settime_old(id: ClockId, timespec: Timespec) -> io::Result<()> {
     use core::convert::TryInto;
     let old_timespec = c::timespec {

src/backend/linux_raw/arch/inline/x86.rs

@@ -113,7 +113,7 @@ pub(in crate::backend) unsafe fn indirect_syscall4(
 ) -> RetReg<R0> {
     let r0;
     // a3 should go in esi, but `asm!` won't let us use it as an operand.
-    // temporarily swap it into place, and then swap it back afterward.
+    // Temporarily swap it into place, and then swap it back afterward.
     //
     // We hard-code the callee operand to use edi instead of `in(reg)` because
     // even though we can't name esi as an operand, the compiler can use esi to

src/backend/linux_raw/elf.rs

@@ -1,4 +1,4 @@
-//! The ELF ABI.
+//! The ELF ABI. 🧝
 
 #![allow(non_snake_case)]
 #![cfg_attr(

src/backend/linux_raw/fs/inotify.rs

@@ -76,6 +76,7 @@ bitflags! {
 /// Use the [`CreateFlags::CLOEXEC`] flag to prevent the resulting file
 /// descriptor from being implicitly passed across `exec` boundaries.
 #[doc(alias = "inotify_init1")]
+#[inline]
 pub fn inotify_init(flags: CreateFlags) -> io::Result<OwnedFd> {
     syscalls::inotify_init1(flags)
 }
@@ -89,6 +90,7 @@ pub fn inotify_init(flags: CreateFlags) -> io::Result<OwnedFd> {
 /// different paths to this method may result in it returning
 /// the same watch descriptor. An application should keep track of this
 /// externally to avoid logic errors.
+#[inline]
 pub fn inotify_add_watch<P: crate::path::Arg>(
     inot: BorrowedFd<'_>,
     path: P,
@@ -103,6 +105,7 @@ pub fn inotify_add_watch<P: crate::path::Arg>(
 /// The watch descriptor provided should have previously been returned
 /// by [`inotify_add_watch`] and not previously have been removed.
 #[doc(alias = "inotify_rm_watch")]
+#[inline]
 pub fn inotify_remove_watch(inot: BorrowedFd<'_>, wd: i32) -> io::Result<()> {
     syscalls::inotify_rm_watch(inot, wd)
 }

src/backend/linux_raw/fs/types.rs

@@ -136,7 +136,7 @@ impl From<RawMode> for Mode {
 }
 
 impl From<Mode> for RawMode {
-    /// Support conversions from `Mode to raw mode values.
+    /// Support conversions from `Mode` to raw mode values.
     ///
     /// ```
     /// use rustix::fs::{Mode, RawMode};

src/backend/linux_raw/io/epoll.rs

@@ -160,6 +160,7 @@ pub fn epoll_create(flags: CreateFlags) -> io::Result<OwnedFd> {
 /// is an `Arc<dyn SystemResource>`, then `epoll` can be thought to maintain
 /// a `Weak<dyn SystemResource>` to the file descriptor.
 #[doc(alias = "epoll_ctl")]
+#[inline]
 pub fn epoll_add(
     epoll: impl AsFd,
     source: impl AsFd,
@@ -185,6 +186,7 @@ pub fn epoll_add(
 ///
 /// This sets the events of interest with `target` to `events`.
 #[doc(alias = "epoll_ctl")]
+#[inline]
 pub fn epoll_mod(
     epoll: impl AsFd,
     source: impl AsFd,
@@ -211,6 +213,7 @@ pub fn epoll_mod(
 ///
 /// This also returns the owning `Data`.
 #[doc(alias = "epoll_ctl")]
+#[inline]
 pub fn epoll_del(epoll: impl AsFd, source: impl AsFd) -> io::Result<()> {
     // SAFETY: We're calling `epoll_ctl` via FFI and we know how it
     // behaves.
@@ -225,6 +228,7 @@ pub fn epoll_del(epoll: impl AsFd, source: impl AsFd) -> io::Result<()> {
 ///
 /// For each event of interest, an element is written to `events`. On
 /// success, this returns the number of written elements.
+#[inline]
 pub fn epoll_wait(
     epoll: impl AsFd,
     event_list: &mut EventVec,
@@ -254,6 +258,7 @@ pub struct Iter<'a> {
 impl<'a> Iterator for Iter<'a> {
     type Item = (EventFlags, u64);
 
+    #[inline]
     fn next(&mut self) -> Option<Self::Item> {
         self.iter
             .next()

src/backend/linux_raw/io/types.rs

@@ -109,7 +109,7 @@ impl<'a> IoSliceRaw<'a> {
     pub fn from_slice(buf: &'a [u8]) -> Self {
         IoSliceRaw {
             _buf: c::iovec {
-                iov_base: buf.as_ptr() as *mut u8 as *mut c::c_void,
+                iov_base: (buf.as_ptr() as *mut u8).cast::<c::c_void>(),
                 iov_len: buf.len() as _,
             },
             _lifetime: PhantomData,
@@ -120,7 +120,7 @@ impl<'a> IoSliceRaw<'a> {
     pub fn from_slice_mut(buf: &'a mut [u8]) -> Self {
         IoSliceRaw {
             _buf: c::iovec {
-                iov_base: buf.as_mut_ptr() as *mut c::c_void,
+                iov_base: buf.as_mut_ptr().cast::<c::c_void>(),
                 iov_len: buf.len() as _,
             },
             _lifetime: PhantomData,

src/backend/linux_raw/net/addr.rs

@@ -59,7 +59,7 @@ impl SocketAddrUnix {
         }
     }
 
-    fn init() -> c::sockaddr_un {
+    const fn init() -> c::sockaddr_un {
         c::sockaddr_un {
             sun_family: c::AF_UNIX as _,
             sun_path: [0; 108],