Conversation
75aa6de to
e217e84
Compare
|
Apologies for the delay -- didn't realize that you were using double quotes! |
|
Thanks for aligning with the existing styles! I just pushed a new release, if you can rebase I will revisit in the morning (GMT +1) |
e217e84 to
9420129
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR introduces configuration and script changes to integrate Prettier into the codebase for consistent code formatting.
- Reformats code in src/extension.ts and esbuild.mjs using Prettier
- Adds Prettier configuration (prettier.config.mjs) and ignore file (.prettierignore)
- Updates package.json, eslint.config.mjs, and commitlint.config.js to incorporate Prettier and its integration plugins
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/extension.ts | Code reformatting using Prettier for clarity and consistency |
| prettier.config.mjs | New Prettier config file to define formatting rules |
| package.json | Added fmt script and dependencies for Prettier and eslint-plugin-prettier |
| eslint.config.mjs | Updated ESLint configuration to include the Prettier plugin |
| esbuild.mjs | Minor formatting adjustments in error logging and configuration |
| commitlint.config.js | Improved formatting for commitlint configuration |
| .prettierignore | New file to ignore specific file types from Prettier formatting |
Comments suppressed due to low confidence (1)
eslint.config.mjs:20
- Consider extending the recommended configuration for eslint-plugin-prettier (e.g., 'plugin:prettier/recommended') to automatically enforce formatting rules and disable conflicting ESLint rules.
plugins: { prettier },
81ff629 to
7c3623c
Compare
|
@vados-cosmonic I made some additional tweaks and appended to this PR. If your happy with those can you squash and I will merge. |
|
Hey @GordonSmith thanks for improving the PR -- It looks like the changes have broken the current CI and may need a rebase 😅 If you wouldn't mind fixing those issues, IMO you can squash-merge this PR any time you want -- I'm certainly happy with the changes! |
7c3623c to
f4590a7
Compare
This commit adds prettier config and integrates directly with eslint Signed-off-by: Victor Adossi <vadossi@cosmonic.com> chore: fmt Signed-off-by: Victor Adossi <vadossi@cosmonic.com> chore: update configuration files and improve CI workflow Signed-off-by: Gordon Smith <GordonJSmith@gmail.com>
f4590a7 to
5127b80
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR integrates Prettier as a formatting tool, adds related scripts/configs, and reformats various files for consistency.
- Introduces
prettier.config.mjsand.prettierignore - Updates
package.jsonto includefmt/fmt-checkscripts and dependencies - Adjusts ESLint and CI workflows to accommodate Prettier
Reviewed Changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| syntaxes/wit.tmLanguage.json | Reformatted fileTypes array to single line |
| src/extension.ts | Reformatted provider and completion list syntax |
| prettier.config.mjs | Added Prettier configuration |
| package.json | Added fmt/fmt-check scripts and Prettier deps |
| language-configuration.json | Reformatted arrays and objects |
| eslint.config.mjs | Added eslint-plugin-prettier, reorganized rules |
| esbuild.mjs | Reformatted arrays and arrow functions |
| .vscode/tasks.json | Reformatted dependsOn array |
| .vscode/settings.json | Added Prettier VSCode settings |
| .vscode/extensions.json | Recommended Prettier/ESLint extensions |
| .prettierignore | Added ignore patterns for Prettier |
| .github/workflows/ci.yml | Updated Node version to 22 |
Comments suppressed due to low confidence (2)
.github/workflows/ci.yml:24
- Add a Prettier check step (e.g.,
run: npm run fmt-check) in CI after installing dependencies to enforce formatting on pull requests.
run: npm ci
eslint.config.mjs:21
- Re-add the Markdown linting configuration for
.mdfiles to ensure documentation is still linted with ESLint.
{ files: ["**/*.md"], plugins: { markdown }, language: "markdown/gfm", extends: ["markdown/recommended"] },
|
🎉 This change has been included in wit-idl-v0.3.5 🎉 The release is available on:
Your release-please bot 🚀🙏 |
Hey there @GordonSmith 👋
I saw some of the work you were doing to get the codebase to be more consistent and wondered if
prettiermight be a good fit along witheslint, it's a great anti-bikeshedding tool.