Merge pull request #218 from alexcrichton/merge

Merge with main

Author: alexcrichton

.github/actions/cancel-on-failure/action.yml

@@ -47,10 +47,6 @@ jobs:
     - run: rustup component add rustfmt
     - run: cargo fmt --all -- --check
 
-    # common logic to cancel the entire run if this job fails
-    - uses: ./.github/actions/cancel-on-failure
-      if: failure()
-
   # Quick JS formatting/linting checks for the little bits of JS we have for the
   # `wasmtime explore` UI.
   check_js:
@@ -65,10 +61,6 @@ jobs:
     - run: npm run fmt-check
       working-directory: ./crates/explorer
 
-    # common logic to cancel the entire run if this job fails
-    - uses: ./.github/actions/cancel-on-failure
-      if: failure()
-
   # Check Code style quickly by running `clang-format` over all the C/C++ code
   #
   # Note that `wasmtime-platform.h` is excluded here as it's auto-generated.
@@ -85,10 +77,6 @@ jobs:
           grep -v wasm.h | \
           xargs clang-format-18 --dry-run --Werror --verbose
 
-    # common logic to cancel the entire run if this job fails
-    - uses: ./.github/actions/cancel-on-failure
-      if: failure()
-
   # Lint dependency graph for security advisories, duplicate versions, and
   # incompatible licences
   cargo_deny:
@@ -108,10 +96,6 @@ jobs:
         echo `pwd` >> $GITHUB_PATH
     - run: cargo deny check bans licenses
 
-    # common logic to cancel the entire run if this job fails
-    - uses: ./.github/actions/cancel-on-failure
-      if: failure()
-
   # Ensure dependencies are vetted. See https://mozilla.github.io/cargo-vet/
   #
   # Note that this step, on PRs only, is allowed to fail. This is then followed
@@ -142,10 +126,6 @@ jobs:
     - run: rustc scripts/publish.rs && ./publish bump-patch && cargo vet
       name: Ensure `cargo vet` works if versions are bumped
 
-    # common logic to cancel the entire run if this job fails
-    - uses: ./.github/actions/cancel-on-failure
-      if: failure()
-
   cargo_vet_failure_for_prs:
     name: Cargo vet failed on a Pull Request
     needs:
@@ -327,10 +307,6 @@ jobs:
         name: gh-pages
         path: gh-pages.tar.gz
 
-    # common logic to cancel the entire run if this job fails
-    - uses: ./.github/actions/cancel-on-failure
-      if: failure()
-
   # Checks of various feature combinations and whether things compile. The goal
   # here isn't to run tests, mostly just serve as a double-check that Rust code
   # compiles and is likely to work everywhere else.
@@ -432,10 +408,6 @@ jobs:
         )
         echo "$checks" | xargs -I CHECK sh -c 'echo "=== cargo check CHECK ==="; cargo check CHECK'
 
-    # common logic to cancel the entire run if this job fails
-    - uses: ./.github/actions/cancel-on-failure
-      if: failure()
-
   special_tests:
     name: One-off special tests
     runs-on: ubuntu-latest
@@ -449,10 +421,6 @@ jobs:
     - run: cargo test -p wasmtime-internal-fiber --no-default-features
     - run: cargo test -p cranelift-tools --test logged-filetests
 
-    # common logic to cancel the entire run if this job fails
-    - uses: ./.github/actions/cancel-on-failure
-      if: failure()
-
   # Check that Clippy lints are passing.
   clippy:
     name: Clippy
@@ -468,10 +436,6 @@ jobs:
     - run: rustup component add clippy
     - run: cargo clippy --workspace --all-targets
 
-    # common logic to cancel the entire run if this job fails
-    - uses: ./.github/actions/cancel-on-failure
-      if: failure()
-
   # Similar to `micro_checks` but where we need to install some more state
   # (e.g. Android NDK) and we haven't factored support for those things out into
   # a parallel jobs yet.
@@ -513,10 +477,6 @@ jobs:
       run: ./ci/vendor-c-api-headers.sh
     - run: git diff --exit-code
 
-    # common logic to cancel the entire run if this job fails
-    - uses: ./.github/actions/cancel-on-failure
-      if: failure()
-
   # Various checks that Wasmtime builds for a variety of platforms. Each
   # platform may not include the entire dependency tree and maybe just a few
   # features here and there, see the `include` matrix for more details.
@@ -601,10 +561,6 @@ jobs:
       env:
         CARGO_BUILD_TARGET: ${{ matrix.target }}
 
-    # common logic to cancel the entire run if this job fails
-    - uses: ./.github/actions/cancel-on-failure
-      if: failure()
-
   # Run tests that require a nightly compiler, such as building fuzz targets.
   test_nightly:
     needs: determine
@@ -647,10 +603,6 @@ jobs:
     - run: cargo fuzz build --dev --fuzz-dir ./crates/environ/fuzz --features component-model
     - run: cargo fuzz build --dev --fuzz-dir ./cranelift/assembler-x64/fuzz
 
-    # common logic to cancel the entire run if this job fails
-    - uses: ./.github/actions/cancel-on-failure
-      if: failure()
-
   # Perform all tests of the c-api
   test_capi:
     needs: determine
@@ -680,10 +632,6 @@ jobs:
     - run: cmake -E env CTEST_OUTPUT_ON_FAILURE=1 cmake --build examples/build --config Debug --target test
       if: runner.os != 'Windows'
 
-    # common logic to cancel the entire run if this job fails
-    - uses: ./.github/actions/cancel-on-failure
-      if: failure()
-
   # Perform all tests (debug mode) for `wasmtime`.
   #
   # Note that the full matrix for what may run here is defined within
@@ -825,10 +773,6 @@ jobs:
     - run: python3 ./ci/run-tests.py --locked ${{ matrix.bucket }}
       shell: pwsh
 
-    # common logic to cancel the entire run if this job fails
-    - uses: ./.github/actions/cancel-on-failure
-      if: failure()
-
   # Test `wasmtime-wasi-nn` in its own job, as not all of its backends are
   # compatible with all targets, and each must be tested separately anyways.
   test_wasi_nn:
@@ -868,10 +812,6 @@ jobs:
     # Run the tests!
     - run: cargo test -p wasmtime-wasi-nn --features ${{ matrix.feature }}
 
-    # common logic to cancel the entire run if this job fails
-    - uses: ./.github/actions/cancel-on-failure
-      if: failure()
-
   # Test the `wasmtime-fuzzing` crate. Split out from the main tests because
   # `--all-features` brings in OCaml, which is a pain to get setup for all
   # targets.
@@ -890,10 +830,6 @@ jobs:
     - run: |
         cargo test -p wasmtime-fuzzing -p wasm-spec-interpreter
 
-    # common logic to cancel the entire run if this job fails
-    - uses: ./.github/actions/cancel-on-failure
-      if: failure()
-
   # Test debug (DWARF) related functionality.
   test_debug_dwarf:
     needs: determine
@@ -922,10 +858,6 @@ jobs:
         LLDB: lldb-15 # override default version, 14
         WASI_SDK_PATH: /tmp/wasi-sdk
 
-    # common logic to cancel the entire run if this job fails
-    - uses: ./.github/actions/cancel-on-failure
-      if: failure()
-
   build-preview1-component-adapter:
     name: Build wasi-preview1-component-adapter
     needs: determine
@@ -955,11 +887,6 @@ jobs:
         name: bins-wasi-preview1-component-adapter
         path: target/wasm32-unknown-unknown/release/wasi_snapshot_preview1.*.wasm
 
-
-    # common logic to cancel the entire run if this job fails
-    - uses: ./.github/actions/cancel-on-failure
-      if: failure()
-
   build-preview1-component-adapter-provider:
     name: Build wasi-preview1-component-adapter-provider
     needs: build-preview1-component-adapter
@@ -973,10 +900,6 @@ jobs:
       with:
         run-id: ${{ github.run_id }}
 
-    # common logic to cancel the entire run if this job fails
-    - uses: ./.github/actions/cancel-on-failure
-      if: failure()
-
   # Verify the "min platform" example still works.
   test-min-platform-example:
     name: Test the min-platform example
@@ -1016,10 +939,6 @@ jobs:
         name: wasmtime-platform-header
         path: examples/min-platform/embedding/wasmtime-platform.h
 
-    # common logic to cancel the entire run if this job fails
-    - uses: ./.github/actions/cancel-on-failure
-      if: failure()
-
   bench:
     needs: determine
     if: needs.determine.outputs.run-full
@@ -1033,10 +952,6 @@ jobs:
     - run: rustup target add wasm32-wasip1
     - run: cargo test --benches --release
 
-    # common logic to cancel the entire run if this job fails
-    - uses: ./.github/actions/cancel-on-failure
-      if: failure()
-
   # Verify that cranelift's code generation is deterministic
   meta_deterministic_check:
     needs: determine
@@ -1051,10 +966,6 @@ jobs:
     - run: cd cranelift/codegen && cargo build --features all-arch
     - run: ci/ensure_deterministic_build.sh
 
-    # common logic to cancel the entire run if this job fails
-    - uses: ./.github/actions/cancel-on-failure
-      if: failure()
-
   verify-publish:
     needs: determine
     if: github.repository == 'bytecodealliance/wasmtime' && needs.determine.outputs.run-full
@@ -1075,10 +986,6 @@ jobs:
     # Make sure we can bump version numbers for the next release
     - run: ./publish bump
 
-    # common logic to cancel the entire run if this job fails
-    - uses: ./.github/actions/cancel-on-failure
-      if: failure()
-
   # Run a subset of tests under MIRI on CI to help check the `unsafe` code in
   # Wasmtime to make sure it's at least not obviously incorrect for basic usage.
   # Note that this doesn't run the full test suite since MIRI can't actually run
@@ -1124,10 +1031,6 @@ jobs:
     - run: ${{ matrix.script }}
       if: ${{ matrix.script }}
 
-    # common logic to cancel the entire run if this job fails
-    - uses: ./.github/actions/cancel-on-failure
-      if: failure()
-
   # Perform release builds of `wasmtime` and `libwasmtime.so`. Builds a variety
   # of platforms and architectures and then uploads the release artifacts to
   # this workflow run's list of artifacts.
@@ -1176,10 +1079,6 @@ jobs:
         name: bins-${{ matrix.build }}
         path: dist
 
-    # common logic to cancel the entire run if this job fails
-    - uses: ./.github/actions/cancel-on-failure
-      if: failure()
-
   # This is a "join node" which depends on all prior workflows. The merge queue,
   # for example, gates on this to ensure that everything has executed
   # successfully.

.github/workflows/main.yml

@@ -34,9 +34,14 @@
 /src/      @bytecodealliance/wasmtime-core-reviewers
 /tests/    @bytecodealliance/wasmtime-core-reviewers
 
+# WASI
+/crates/wasi* @bytecodealliance/wasmtime-wasi-reviewers
+
 # Cranelift/Winch compilers
-/cranelift/ @bytecodealliance/wasmtime-compiler-reviewers
-/winch/     @bytecodealliance/wasmtime-compiler-reviewers
+/cranelift/       @bytecodealliance/wasmtime-compiler-reviewers
+/winch/           @bytecodealliance/wasmtime-compiler-reviewers
+/crates/cranelift @bytecodealliance/wasmtime-compiler-reviewers
+/crates/winch     @bytecodealliance/wasmtime-compiler-reviewers
 
 # Fuzz testing
 /fuzz/          @bytecodealliance/wasmtime-fuzz-reviewers