This repository was archived by the owner on Sep 8, 2025. It is now read-only.
fix save/restore of PC/FP/SP/limit on fiber switch#107
Merged
Conversation
dicej
force-pushed
the
dicej/fiber-switch-save-restore
branch
from
86e60bf to
f4324b4
Compare
alexcrichton
approved these changes
Apr 4, 2025
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Collaborator
Author
|
Looks like this is broken on MacOS; I just reproduced it locally on my M1 Macbook Air. Interestingly, it works fine on Asahi Linux on my Mac Mini M2 Pro and breaks on MacOS x86_64, so it appears to be MacOS -specific. |
dicej
force-pushed
the
dicej/fiber-switch-save-restore
branch
5 times, most recently
from
04e1f26 to
5096a1f
Compare
This fixes stack backtrace panics/SIGSEGVs due to broken `CallThreadState`/`VMStoreContext` PC/FP/SP/limit info which wasn't been updated correctly for nested fiber invocations. Thanks to Alex for walking me through the code and sketching the solution. Fixes #102 Signed-off-by: Joel Dice <joel.dice@fermyon.com>
dicej
force-pushed
the
dicej/fiber-switch-save-restore
branch
from
5096a1f to
ed9f304
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes stack backtrace panics/SIGSEGVs due to broken
CallThreadState/VMStoreContextPC/FP/SP/limit info which wasn't been updated correctly for nested fiber invocations.Thanks to Alex for walking me through the code and sketching the solution.
Fixes #102