This repository was archived by the owner on Sep 8, 2025. It is now read-only.
document more unsafe code#154
Merged
Merged
Conversation
This also adds an `unsafe` modifier to additional functions where appropriate, and removes redundant `StoreContextMut` parameters where the store can be derived from the `ComponentInstance`. Signed-off-by: Joel Dice <joel.dice@fermyon.com>
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Collaborator
Author
|
@alexcrichton do you happen to know why the merge queue keeps rejecting this? It doesn't look like there are any test failures. |
Member
|
It's this, stuck in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also adds an
unsafemodifier to additional functions where appropriate, and removes redundantStoreContextMutparameters where the store can be derived from theComponentInstance.