This repository was archived by the owner on Sep 8, 2025. It is now read-only.
add comments to unsafe code in concurrent.rs#147
Merged
Conversation
This also removes a few cases of `unsafe` that turned out to be unnecessary, as well as adding the `unsafe` modifier to a few functions where appropriate. `futures_and_streams.rs` also has quite a few `unsafe` blocks; I'll tackle those next. Signed-off-by: Joel Dice <joel.dice@fermyon.com>
dicej
force-pushed
the
dicej/concurrent-rs-unsafe-comments
branch
from
8f5983f to
881ab36
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also removes a few cases of
unsafethat turned out to be unnecessary, as well as adding theunsafemodifier to a few functions where appropriate.futures_and_streams.rsalso has quite a fewunsafeblocks; I'll tackle those next.