This repository was archived by the owner on Sep 8, 2025. It is now read-only.
update future/stream ABIs and names#203
Merged
Merged
Conversation
This updates `wasmtime-environ`, `wasmtime-cranelift`, and `wasmtime` to to use (some of) the new ABI defined in WebAssembly/component-model#524. It covers everything in that PR _except_ the lifting and lowering changes to `future.{read,write}`, which we decided are more trouble than they're worth. Still to do: add tests for the following items (Luke has volunteered to do this): > * When a `future` is "done" (by a `COMPLETED` read/write or by the writable end receiving `DROPPED`), the only valid operation is `future.drop-{readable,writable}`. `future.{read,write}` or lifting traps. > * Because there's no great reason for streams to be more permissive than futures in this regard, streams are also given a "done" state with the same trapping rules as futures, but the stream "done" state is only set when `DROPPED` is received. Signed-off-by: Joel Dice <joel.dice@fermyon.com>
alexcrichton
approved these changes
Jun 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates
wasmtime-environ,wasmtime-cranelift, andwasmtimeto to use (some of) the new ABI defined inWebAssembly/component-model#524. It covers everything in that PR except the lifting and lowering changes to
future.{read,write}, which we decided are more trouble than they're worth.Still to do: add tests for the following items (Luke has volunteered to do this):