This repository was archived by the owner on Sep 8, 2025. It is now read-only.
make it easier to run component-async-tests with miri#216
Merged
Conversation
This refactors the test harness a bit to allow running them under miri by first setting `MIRI_TEST_CWASM_DIR` to point to a directory, then running the tests _without_ miri to populate that directory with .cwasm files as a side effect, and finally running the tests _with_ miri, in which case they'll use the already-generated .cwasm files. This avoids the prohibitive cost of compiling significant amounts of guest code under miri. For example: ``` mkdir cwasms MIRI_TEST_CWASM_DIR=$(pwd)/cwasms cargo test -p component-async-tests scenario::round_trip::async_round_trip_stackless -- --exact MIRIFLAGS="-Zmiri-backtrace=full -Zmiri-disable-isolation -Zmiri-permissive-provenance" cargo +nightly miri test -p component-async-tests scenario::round_trip::async_round_trip_stackless -- --exact ``` Signed-off-by: Joel Dice <joel.dice@fermyon.com>
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This won't work on all platforms (e.g. 32-bit ones where Pulley is used). Signed-off-by: Joel Dice <joel.dice@fermyon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactors the test harness a bit to allow running them under miri by first setting
MIRI_TEST_CWASM_DIRto point to a directory, then running the tests without miri to populate that directory with .cwasm files as a side effect, and finally running the tests with miri, in which case they'll use the already-generated .cwasm files. This avoids the prohibitive cost of compiling significant amounts of guest code under miri.For example: