This repository was archived by the owner on Sep 8, 2025. It is now read-only.
Merged
Conversation
A small amount of `unsafe` code is required to enable this but the recent refactorings to use `Pin<&mut ComponentInstance>` everywhere makes this a much easier piece of `unsafe` code to verify.
Similar to previous refactorings which handles the imported/exported distinction in wasm instead of in host code this updates the `table.fill`-related libcall intrinsics to take a defined table index instead of a general table index, enabling using a currently-safer helper function.
This adds missing `Debug` implementations for `Host{Future,Stream}`
which enables turning on `tracing`.
Closes #11245
* Rename `Instance::run_with` to `Instance::run_concurrent` This commit renames `run_with` to `run_concurrent` and additionally deletes the `Instance::run` method. With `Accessor`-related changes there's no need to have a "just run with a future" method as almost everything is going to require `run_concurrent` anyway to acquire an accessor. Closes #11224 * Fix compile issues * Update crates/wasmtime/src/runtime/component/func/typed.rs Co-authored-by: Joel Dice <joel.dice@fermyon.com> --------- Co-authored-by: Joel Dice <joel.dice@fermyon.com>
* evex prefix for new assembler, vaddpd inst, prtest:full * review: refactor `VexLength` and `EvexLength` into a single `Length` * review: fix order of instruction definition to match manual Also, adds some missing `.r()` helpers for consistency. * review: remove opmask registers and mask kind for now This will require more work to expose these as special, runtime-available flags on the generated instruction. * review: remove as-yet unknown operand patterns for EVEX It's likely they will share logic with the VEX patterns but we can refactor that in the future. * review: fix up the `mmm` bit field, document * fix: use new `Length` name in doc tests * review: rename `VexW` to `WBit` * Ensure VEX instructions cannot be defined with `Length::L512` * Use `WBit` in REX instructions --------- Co-authored-by: Andrew Brown <andrew.brown@intel.com>
This commit updates the various methods of `Stream{Reader,Writer}` to
take a mutable reference to `self` instead of `self`-by-value. This is
something which I personally feel is more idiomatic and avoids
cumbersome and possibly frequent move-in-and-move-out style code. This
is additionally coupled with a new `is_closed` method on each of these
types to determine if the stream's other end has been closed after the
last read/write operation.
Closes #11219
This fixes a fuzz failure with the new async tests which require more than one stack.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.