Skip to content
This repository was archived by the owner on Sep 8, 2025. It is now read-only.

refactor {Stream,Future}|{Reader,Writer} APIs and internals #240

Merged
dicej merged 5 commits into from
Jul 25, 2025
Merged

refactor {Stream,Future}|{Reader,Writer} APIs and internals #240

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b4e74e7
refactor `{Stream,Future}|{Reader,Writer}` APIs and internals
dicej Jul 17, 2025
15a1a3b
remove `TcpStream::set_nodelay` call
dicej Jul 25, 2025
a265abf
always drop futures with `&Accessor` fields using `tls::set`
dicej Jul 25, 2025
304a7f1
avoid allocating oneshot channel in `watch_{reader,writer}`
dicej Jul 25, 2025
15c4c76
Add more domains to tls_sample_application (#11265)
alexcrichton Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions crates/component-macro/tests/expanded/char_concurrent.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ pub mod foo {
"take-char",
move |caller: &wasmtime::component::Accessor<T>, (arg0,): (char,)| {
wasmtime::component::__internal::Box::pin(async move {
let accessor = &mut unsafe { caller.with_data(host_getter) };
let accessor = &caller.with_data(host_getter);
let r = <D as HostConcurrent>::take_char(accessor, arg0)
.await;
Ok(r)
Expand All @@ -217,7 +217,7 @@ pub mod foo {
"return-char",
move |caller: &wasmtime::component::Accessor<T>, (): ()| {
wasmtime::component::__internal::Box::pin(async move {
let accessor = &mut unsafe { caller.with_data(host_getter) };
let accessor = &caller.with_data(host_getter);
let r = <D as HostConcurrent>::return_char(accessor).await;
Ok((r,))
})
Expand Down
24 changes: 12 additions & 12 deletions crates/component-macro/tests/expanded/conventions_concurrent.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,7 @@ pub mod foo {
"kebab-case",
move |caller: &wasmtime::component::Accessor<T>, (): ()| {
wasmtime::component::__internal::Box::pin(async move {
let accessor = &mut unsafe { caller.with_data(host_getter) };
let accessor = &caller.with_data(host_getter);
let r = <D as HostConcurrent>::kebab_case(accessor).await;
Ok(r)
})
Expand All @@ -307,7 +307,7 @@ pub mod foo {
(arg0,): (LudicrousSpeed,)|
{
wasmtime::component::__internal::Box::pin(async move {
let accessor = &mut unsafe { caller.with_data(host_getter) };
let accessor = &caller.with_data(host_getter);
let r = <D as HostConcurrent>::foo(accessor, arg0).await;
Ok(r)
})
Expand All @@ -317,7 +317,7 @@ pub mod foo {
"function-with-dashes",
move |caller: &wasmtime::component::Accessor<T>, (): ()| {
wasmtime::component::__internal::Box::pin(async move {
let accessor = &mut unsafe { caller.with_data(host_getter) };
let accessor = &caller.with_data(host_getter);
let r = <D as HostConcurrent>::function_with_dashes(accessor)
.await;
Ok(r)
Expand All @@ -328,7 +328,7 @@ pub mod foo {
"function-with-no-weird-characters",
move |caller: &wasmtime::component::Accessor<T>, (): ()| {
wasmtime::component::__internal::Box::pin(async move {
let accessor = &mut unsafe { caller.with_data(host_getter) };
let accessor = &caller.with_data(host_getter);
let r = <D as HostConcurrent>::function_with_no_weird_characters(
accessor,
)
Expand All @@ -341,7 +341,7 @@ pub mod foo {
"apple",
move |caller: &wasmtime::component::Accessor<T>, (): ()| {
wasmtime::component::__internal::Box::pin(async move {
let accessor = &mut unsafe { caller.with_data(host_getter) };
let accessor = &caller.with_data(host_getter);
let r = <D as HostConcurrent>::apple(accessor).await;
Ok(r)
})
Expand All @@ -351,7 +351,7 @@ pub mod foo {
"apple-pear",
move |caller: &wasmtime::component::Accessor<T>, (): ()| {
wasmtime::component::__internal::Box::pin(async move {
let accessor = &mut unsafe { caller.with_data(host_getter) };
let accessor = &caller.with_data(host_getter);
let r = <D as HostConcurrent>::apple_pear(accessor).await;
Ok(r)
})
Expand All @@ -361,7 +361,7 @@ pub mod foo {
"apple-pear-grape",
move |caller: &wasmtime::component::Accessor<T>, (): ()| {
wasmtime::component::__internal::Box::pin(async move {
let accessor = &mut unsafe { caller.with_data(host_getter) };
let accessor = &caller.with_data(host_getter);
let r = <D as HostConcurrent>::apple_pear_grape(accessor)
.await;
Ok(r)
Expand All @@ -372,7 +372,7 @@ pub mod foo {
"a0",
move |caller: &wasmtime::component::Accessor<T>, (): ()| {
wasmtime::component::__internal::Box::pin(async move {
let accessor = &mut unsafe { caller.with_data(host_getter) };
let accessor = &caller.with_data(host_getter);
let r = <D as HostConcurrent>::a0(accessor).await;
Ok(r)
})
Expand All @@ -382,7 +382,7 @@ pub mod foo {
"is-XML",
move |caller: &wasmtime::component::Accessor<T>, (): ()| {
wasmtime::component::__internal::Box::pin(async move {
let accessor = &mut unsafe { caller.with_data(host_getter) };
let accessor = &caller.with_data(host_getter);
let r = <D as HostConcurrent>::is_xml(accessor).await;
Ok(r)
})
Expand All @@ -392,7 +392,7 @@ pub mod foo {
"explicit",
move |caller: &wasmtime::component::Accessor<T>, (): ()| {
wasmtime::component::__internal::Box::pin(async move {
let accessor = &mut unsafe { caller.with_data(host_getter) };
let accessor = &caller.with_data(host_getter);
let r = <D as HostConcurrent>::explicit(accessor).await;
Ok(r)
})
Expand All @@ -402,7 +402,7 @@ pub mod foo {
"explicit-kebab",
move |caller: &wasmtime::component::Accessor<T>, (): ()| {
wasmtime::component::__internal::Box::pin(async move {
let accessor = &mut unsafe { caller.with_data(host_getter) };
let accessor = &caller.with_data(host_getter);
let r = <D as HostConcurrent>::explicit_kebab(accessor)
.await;
Ok(r)
Expand All @@ -413,7 +413,7 @@ pub mod foo {
"bool",
move |caller: &wasmtime::component::Accessor<T>, (): ()| {
wasmtime::component::__internal::Box::pin(async move {
let accessor = &mut unsafe { caller.with_data(host_getter) };
let accessor = &caller.with_data(host_getter);
let r = <D as HostConcurrent>::bool(accessor).await;
Ok(r)
})
Expand Down
2 changes: 1 addition & 1 deletion crates/component-macro/tests/expanded/dead-code_concurrent.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ pub mod a {
"f",
move |caller: &wasmtime::component::Accessor<T>, (): ()| {
wasmtime::component::__internal::Box::pin(async move {
let accessor = &mut unsafe { caller.with_data(host_getter) };
let accessor = &caller.with_data(host_getter);
let r = <D as HostConcurrent>::f(accessor).await;
Ok((r,))
})
Expand Down
2 changes: 1 addition & 1 deletion crates/component-macro/tests/expanded/direct-import_concurrent.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ const _: () = {
"foo",
move |caller: &wasmtime::component::Accessor<T>, (): ()| {
wasmtime::component::__internal::Box::pin(async move {
let accessor = &mut unsafe { caller.with_data(host_getter) };
let accessor = &caller.with_data(host_getter);
let r = <D as FooImportsConcurrent>::foo(accessor).await;
Ok(r)
})
Expand Down
14 changes: 7 additions & 7 deletions crates/component-macro/tests/expanded/flags_concurrent.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,7 @@ pub mod foo {
"roundtrip-flag1",
move |caller: &wasmtime::component::Accessor<T>, (arg0,): (Flag1,)| {
wasmtime::component::__internal::Box::pin(async move {
let accessor = &mut unsafe { caller.with_data(host_getter) };
let accessor = &caller.with_data(host_getter);
let r = <D as HostConcurrent>::roundtrip_flag1(
accessor,
arg0,
Expand All @@ -363,7 +363,7 @@ pub mod foo {
"roundtrip-flag2",
move |caller: &wasmtime::component::Accessor<T>, (arg0,): (Flag2,)| {
wasmtime::component::__internal::Box::pin(async move {
let accessor = &mut unsafe { caller.with_data(host_getter) };
let accessor = &caller.with_data(host_getter);
let r = <D as HostConcurrent>::roundtrip_flag2(
accessor,
arg0,
Expand All @@ -377,7 +377,7 @@ pub mod foo {
"roundtrip-flag4",
move |caller: &wasmtime::component::Accessor<T>, (arg0,): (Flag4,)| {
wasmtime::component::__internal::Box::pin(async move {
let accessor = &mut unsafe { caller.with_data(host_getter) };
let accessor = &caller.with_data(host_getter);
let r = <D as HostConcurrent>::roundtrip_flag4(
accessor,
arg0,
Expand All @@ -391,7 +391,7 @@ pub mod foo {
"roundtrip-flag8",
move |caller: &wasmtime::component::Accessor<T>, (arg0,): (Flag8,)| {
wasmtime::component::__internal::Box::pin(async move {
let accessor = &mut unsafe { caller.with_data(host_getter) };
let accessor = &caller.with_data(host_getter);
let r = <D as HostConcurrent>::roundtrip_flag8(
accessor,
arg0,
Expand All @@ -405,7 +405,7 @@ pub mod foo {
"roundtrip-flag16",
move |caller: &wasmtime::component::Accessor<T>, (arg0,): (Flag16,)| {
wasmtime::component::__internal::Box::pin(async move {
let accessor = &mut unsafe { caller.with_data(host_getter) };
let accessor = &caller.with_data(host_getter);
let r = <D as HostConcurrent>::roundtrip_flag16(
accessor,
arg0,
Expand All @@ -419,7 +419,7 @@ pub mod foo {
"roundtrip-flag32",
move |caller: &wasmtime::component::Accessor<T>, (arg0,): (Flag32,)| {
wasmtime::component::__internal::Box::pin(async move {
let accessor = &mut unsafe { caller.with_data(host_getter) };
let accessor = &caller.with_data(host_getter);
let r = <D as HostConcurrent>::roundtrip_flag32(
accessor,
arg0,
Expand All @@ -433,7 +433,7 @@ pub mod foo {
"roundtrip-flag64",
move |caller: &wasmtime::component::Accessor<T>, (arg0,): (Flag64,)| {
wasmtime::component::__internal::Box::pin(async move {
let accessor = &mut unsafe { caller.with_data(host_getter) };
let accessor = &caller.with_data(host_getter);
let r = <D as HostConcurrent>::roundtrip_flag64(
accessor,
arg0,
Expand Down
8 changes: 4 additions & 4 deletions crates/component-macro/tests/expanded/floats_concurrent.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ pub mod foo {
"f32-param",
move |caller: &wasmtime::component::Accessor<T>, (arg0,): (f32,)| {
wasmtime::component::__internal::Box::pin(async move {
let accessor = &mut unsafe { caller.with_data(host_getter) };
let accessor = &caller.with_data(host_getter);
let r = <D as HostConcurrent>::f32_param(accessor, arg0)
.await;
Ok(r)
Expand All @@ -228,7 +228,7 @@ pub mod foo {
"f64-param",
move |caller: &wasmtime::component::Accessor<T>, (arg0,): (f64,)| {
wasmtime::component::__internal::Box::pin(async move {
let accessor = &mut unsafe { caller.with_data(host_getter) };
let accessor = &caller.with_data(host_getter);
let r = <D as HostConcurrent>::f64_param(accessor, arg0)
.await;
Ok(r)
Expand All @@ -239,7 +239,7 @@ pub mod foo {
"f32-result",
move |caller: &wasmtime::component::Accessor<T>, (): ()| {
wasmtime::component::__internal::Box::pin(async move {
let accessor = &mut unsafe { caller.with_data(host_getter) };
let accessor = &caller.with_data(host_getter);
let r = <D as HostConcurrent>::f32_result(accessor).await;
Ok((r,))
})
Expand All @@ -249,7 +249,7 @@ pub mod foo {
"f64-result",
move |caller: &wasmtime::component::Accessor<T>, (): ()| {
wasmtime::component::__internal::Box::pin(async move {
let accessor = &mut unsafe { caller.with_data(host_getter) };
let accessor = &caller.with_data(host_getter);
let r = <D as HostConcurrent>::f64_result(accessor).await;
Ok((r,))
})
Expand Down
2 changes: 1 addition & 1 deletion crates/component-macro/tests/expanded/host-world_concurrent.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ const _: () = {
"foo",
move |caller: &wasmtime::component::Accessor<T>, (): ()| {
wasmtime::component::__internal::Box::pin(async move {
let accessor = &mut unsafe { caller.with_data(host_getter) };
let accessor = &caller.with_data(host_getter);
let r = <D as Host_ImportsConcurrent>::foo(accessor).await;
Ok(r)
})
Expand Down
Loading