This repository was archived by the owner on Sep 8, 2025. It is now read-only.
various fixes related to stream/future cancellation#89
Merged
Conversation
Most of this is related to the delay between queuing an event (e.g. read completion) and delivering it; a guest could cancel inbetween, and we should allow that rather than trap. Also, we need to be careful to invalidate any queued events as part of cancellation, especially given that the guest could cancel and close a stream or future before delivery. This code is getting uglier with time and will likely need to be cleaned up and refactored before it is upstreamed. Fixes #84 Signed-off-by: Joel Dice <joel.dice@fermyon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most of this is related to the delay between queuing an event (e.g. read completion) and delivering it; a guest could cancel inbetween, and we should allow that rather than trap.
Also, we need to be careful to invalidate any queued events as part of cancellation, especially given that the guest could cancel and close a stream or future before delivery.
This code is getting uglier with time and will likely need to be cleaned up and refactored before it is upstreamed.
Fixes #84