Skip to content

Commit 1ed0a15

Browse files
committed
Stop pretending to support extended-const proposal
As far as I know, we don't implement the proposal at all. At least, we don't implement even very basic cases like: ``` spacetanuki% wasm2wat --enable-all data.28.wasm (module (memory (;0;) 1) (data (;0;) (i32.const 42 i32.const 0 i32.sub) "")) spacetanuki% toywasm --load data.28.wasm spacetanuki% ~/git/wasm-micro-runtime/product-mini/platforms/darwin/b.classic/iwasm data.28.wasm WASM module load failed: illegal opcode or constant expression required or type mismatch spacetanuki% ``` data.28.wasm in the above example is a binary version of: https://github.com/WebAssembly/extended-const/blob/8d4f6aa2b00a8e7c0174410028625c6a176db8a1/test/core/data.wast#L184-L187
1 parent 0a8994a commit 1ed0a15

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

build-scripts/config_common.cmake

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -677,7 +677,6 @@ endif ()
677677
message (
678678
"-- About Wasm Proposals:\n"
679679
" Always-on:\n"
680-
" \"Extended Constant Expressions\"\n"
681680
" \"Multi-value\"\n"
682681
" \"Non-trapping float-to-int conversions\"\n"
683682
" \"Sign-extension operators\"\n"
@@ -695,6 +694,7 @@ message (
695694
" \"Threads\" via WAMR_BUILD_SHARED_MEMORY: ${WAMR_BUILD_SHARED_MEMORY}\n"
696695
" \"Typed Function References\" via WAMR_BUILD_GC: ${WAMR_BUILD_GC}\n"
697696
" Unsupported (>= Phase4):\n"
697+
" \"Extended Constant Expressions\"\n"
698698
" \"Branch Hinting\"\n"
699699
" \"Custom Annotation Syntax in the Text Format\"\n"
700700
" \"Exception handling\"\n"

doc/stability_wasm_proposals.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ Users can turn those features on or off by using compilation options. If a relev
1515
| Proposal | >= Phase 4 | Compilation Option |
1616
| ------------------------------------- | ---------- | ------------------------ |
1717
| Bulk memory operations | Yes | `WAMR_BUILD_BULK_MEMORY` |
18-
| Extended Constant Expressions | Yes | N/A |
1918
| Fixed-width SIMD[^1] | Yes | `WAMR_BUILD_SIMD` |
2019
| Multi-value | Yes | N/A |
2120
| Non-trapping float-to-int conversions | Yes | N/A |
@@ -51,6 +50,7 @@ Users can turn those features on or off by using compilation options. If a relev
5150

5251
| Proposal | >= Phase 4 |
5352
| ------------------------------------------- | ---------- |
53+
| Extended Constant Expressions | Yes |
5454
| Branch Hinting | Yes |
5555
| Custom Annotation Syntax in the Text Format | Yes |
5656
| Exception handling[^5] | Yes |

product-mini/platforms/common/wasm_proposal.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ wasm_proposal_print_status(void)
1212
{
1313
printf("About Wasm Proposals:\n");
1414
printf(" Always-on:\n");
15-
printf(" - Extended Constant Expressions\n");
1615
printf(" - Multi-value\n");
1716
printf(" - Non-trapping float-to-int conversions\n");
1817
printf(" - Sign-extension operators\n");
@@ -41,6 +40,7 @@ wasm_proposal_print_status(void)
4140
printf(" - Typed Function References via WASM_ENABLE_GC: %u\n",
4241
WASM_ENABLE_GC);
4342
printf(" Unsupported (>= Phase4):\n");
43+
printf(" - Extended Constant Expressions\n");
4444
printf(" - Branch Hinting\n");
4545
printf(" - Custom Annotation Syntax in the Text Format\n");
4646
printf(" - Exception handling\n");

0 commit comments

Comments
 (0)