Address reviewer feedback on exception-handling unit tests

- CMakeLists.txt: Follow the interpreter test pattern by adding
  DRUN_ON_LINUX definition, consistent spacing for set() calls,
  and comment before add_executable
- CMakeLists.txt (parent): Register exception-handling subdirectory
  so the test is included in the build
- exception_handling_test.cc: Replace GTEST_SKIP on module load
  failure with ASSERT_NE to fail the test instead of skipping
- exception_handling_test.cc: Replace if(!ok) conditional with
  ASSERT_TRUE on wasm_runtime_call_wasm return value, using
  wasm_runtime_get_exception for the failure message

Author: sumleo

tests/unit/CMakeLists.txt

@@ -65,6 +65,7 @@ add_subdirectory(gc)
 add_subdirectory(tid-allocator)
 add_subdirectory(unsupported-features)
 add_subdirectory(smart-tests)
+add_subdirectory(exception-handling)
 
 if (NOT WAMR_BUILD_TARGET STREQUAL "X86_32")
   add_subdirectory(aot-stack-frame)

tests/unit/exception-handling/CMakeLists.txt

@@ -5,13 +5,15 @@ cmake_minimum_required(VERSION 3.14)
 
 project (test-exception-handling)
 
+add_definitions (-DRUN_ON_LINUX)
+
 add_definitions (-Dattr_container_malloc=malloc)
 add_definitions (-Dattr_container_free=free)
 
-set(WAMR_BUILD_AOT 0)
-set(WAMR_BUILD_INTERP 1)
-set(WAMR_BUILD_FAST_INTERP 0)
-set(WAMR_BUILD_JIT 0)
+set (WAMR_BUILD_AOT 0)
+set (WAMR_BUILD_INTERP 1)
+set (WAMR_BUILD_FAST_INTERP 0)
+set (WAMR_BUILD_JIT 0)
 set (WAMR_BUILD_LIBC_WASI 0)
 set (WAMR_BUILD_APP_FRAMEWORK 0)
 set (WAMR_BUILD_EXCE_HANDLING 1)
@@ -30,6 +32,7 @@ set (unit_test_sources
   ${WAMR_RUNTIME_LIB_SOURCE}
 )
 
+# Now simply link against gtest or gtest_main as needed. Eg
 add_executable (exception_handling_test ${unit_test_sources})
 
 target_link_libraries (exception_handling_test gtest_main)

tests/unit/exception-handling/exception_handling_test.cc

@@ -94,9 +94,7 @@ TEST_F(ExceptionHandlingTest, load_module_with_exception_handling)
     wasm_module_t module = wasm_runtime_load(
         wasm_eh, sizeof(wasm_eh), error_buf, sizeof(error_buf));
 
-    if (!module) {
-        GTEST_SKIP() << "Module load failed: " << error_buf;
-    }
+    ASSERT_NE(module, nullptr) << "Module load failed: " << error_buf;
 
     wasm_module_inst_t inst = wasm_runtime_instantiate(
         module, 8192, 8192, error_buf, sizeof(error_buf));
@@ -111,11 +109,8 @@ TEST_F(ExceptionHandlingTest, load_module_with_exception_handling)
     ASSERT_NE(exec_env, nullptr) << "Failed to create exec env";
 
     bool ok = wasm_runtime_call_wasm(exec_env, func, 0, NULL);
-    if (!ok) {
-        const char *exception = wasm_runtime_get_exception(inst);
-        EXPECT_NE(exception, nullptr)
-            << "Call failed but no exception was set";
-    }
+    ASSERT_TRUE(ok) << "wasm_runtime_call_wasm failed: "
+                    << wasm_runtime_get_exception(inst);
 
     wasm_runtime_destroy_exec_env(exec_env);
     wasm_runtime_deinstantiate(inst);