Skip to content

Commit 6851714

Browse files
committed
cr suggestions
1 parent 1c1066d commit 6851714

2 files changed

Lines changed: 7 additions & 5 deletions

File tree

core/iwasm/compilation/aot_llvm.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3206,7 +3206,7 @@ aot_create_comp_context(const AOTCompData *comp_data, aot_comp_option_t option)
32063206
WASMModule *wasm_module = (WASMModule *)comp_data->wasm_module;
32073207
bool is_memory64 = false;
32083208

3209-
/* TODO: multi-memories for now assuming the memory idx type is
3209+
/* TODO: multi-memories for now assuming the memory64 flag of a memory is
32103210
* consistent across multi-memories */
32113211
if (wasm_module->import_memory_count > 0)
32123212
is_memory64 = !!(wasm_module->import_memories[0].u.memory.mem_type.flags

wamr-compiler/main.c

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -137,10 +137,12 @@ print_help()
137137
printf(" 3 - Small code model\n");
138138
printf(" -sgx Generate code for SGX platform (Intel Software Guard Extensions)\n");
139139
printf(" --bounds-checks=1/0 Enable or disable the bounds checks for memory access:\n");
140-
printf(" By default, it is disabled on all 64-bit platforms except SGX or when\n");
141-
printf(" memory64 is enabled. In these platform and feature combinations,\n");
142-
printf(" the runtime performs bounds checks with a hardware trap;\n");
143-
printf(" By default, it is enabled on all 32-bit platforms or when using memory64.\n");
140+
printf(" This flag controls bounds checking with a software check. \n");
141+
printf(" On 64-bit platforms, it is disabled by default, using a hardware \n");
142+
printf(" trap if supported, except when SGX or memory64 is enabled,\n");
143+
printf(" which defaults to a software check.\n");
144+
printf(" On 32-bit platforms, the flag is enabled by default, using a software check\n");
145+
printf(" due to the lack of hardware support.\n");
144146
printf(" CAVEAT: --bounds-checks=0 enables some optimizations\n");
145147
printf(" which make the compiled AOT module incompatible\n");
146148
printf(" with a runtime without the hardware bounds checks.\n");

0 commit comments

Comments
 (0)