Skip to content

optimize:moving invariant computations outside the loop#4127

Closed
chenliuyang1989 wants to merge 4 commits intobytecodealliance:mainfrom
chenliuyang1989:main
Closed

optimize:moving invariant computations outside the loop#4127
chenliuyang1989 wants to merge 4 commits intobytecodealliance:mainfrom
chenliuyang1989:main

Conversation

@chenliuyang1989
Copy link
Copy Markdown
Contributor

moving invariant computations outside the loop
& reducing the frequency of type casting

moving invariant computations outside the loop
& reducing the frequency of type casting
Copy link
Copy Markdown
Contributor

@lum1n0us lum1n0us left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TianlongLiang
Copy link
Copy Markdown
Contributor

Maybe it's best to create a separate PR for the modification of devcontainer?

@chenliuyang1989
Copy link
Copy Markdown
Contributor Author

Maybe it's best to create a separate PR for the modification of devcontainer?

ok, i will remove the the modification of devcontainer. i close this one and create one separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants