Add missing V128 handling in WASM_OP_BR, reported in #4173#4203
Merged
loganek merged 1 commit intobytecodealliance:mainfrom Apr 22, 2025
Merged
Add missing V128 handling in WASM_OP_BR, reported in #4173#4203loganek merged 1 commit intobytecodealliance:mainfrom
loganek merged 1 commit intobytecodealliance:mainfrom
Conversation
jammar1
requested review from
TianlongLiang,
loganek,
lum1n0us,
no1wudi,
wenyongh,
xujuntwt95329 and
yamt
as code owners
Contributor
|
Thanks, that looks good. Do you think it'd be good to add tests either in WAMR or to the spec test repo? |
Contributor
Author
|
I added a small example in the linked issue. I can add that as a test but it's hard to see how it can re-occur. I'll also need to add a similar statement for when WASM_ENABLE_GC is true. |
lum1n0us
reviewed
Apr 17, 2025
jammar1
force-pushed
the
jammar1/fix-br-v128
branch
from
4ff78ef to
0702f78
Compare
lum1n0us
reviewed
Apr 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.