wasm_export.h: Use "default" visibility for gcc and clang (#3957)#4204
Closed
midokura-xavi92 wants to merge 1 commit intobytecodealliance:mainfrom
Closed
wasm_export.h: Use "default" visibility for gcc and clang (#3957)#4204midokura-xavi92 wants to merge 1 commit intobytecodealliance:mainfrom
midokura-xavi92 wants to merge 1 commit intobytecodealliance:mainfrom
Conversation
…liance#3957) Since the top-level CMakelists.txt is appending `-fvisibility=hidden` to the compile options, no public symbols are exported by default. This forbids users from linking against the shared library. Using `gcc/clang` attributes [1], it is possible to override the definition for `WASM_RUNTIME_API_EXTERN` so that only required symbols are correctly exported. [1]: https://gcc.gnu.org/onlinedocs/gcc/Common-Function-Attributes.html#Common-Function-Attributes
midokura-xavi92
requested review from
TianlongLiang,
loganek,
lum1n0us,
no1wudi,
wenyongh,
xujuntwt95329 and
yamt
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the top-level CMakelists.txt is appending
-fvisibility=hiddento the compile options, no public symbols are exported by default. This forbids users from linking against the shared library.Using
gcc/clangattributes 1, it is possible to override the definition forWASM_RUNTIME_API_EXTERNso that only required symbols are correctly exported.