Shared heap enhancement for AOT and update tests and samples#4226
Conversation
|
The CI issue is due to the update of LLVM, which will be resolved after rebasing the dev branch |
TianlongLiang
requested review from
loganek,
lum1n0us,
no1wudi,
wenyongh,
xujuntwt95329 and
yamt
as code owners
| LLVMBasicBlockRef check_succ, LLVMValueRef maddr_phi, | ||
| LLVMValueRef start_offset, LLVMValueRef max_addr, | ||
| LLVMValueRef mem_base_addr, LLVMValueRef bytes, uint32 bytes_u32, | ||
| bool is_memory64, bool is_target_64bit, bool bulk_memory, bool enable_segue) |
There was a problem hiding this comment.
Might need comments to explain what each variable stands for.
There was a problem hiding this comment.
Will add more comments in the new refactored function
| LLVMBasicBlockRef check_succ, LLVMValueRef maddr_phi, | ||
| LLVMValueRef start_offset, LLVMValueRef max_addr, | ||
| LLVMValueRef mem_base_addr, LLVMValueRef bytes, uint32 bytes_u32, | ||
| bool is_memory64, bool is_target_64bit, bool bulk_memory, bool enable_segue) |
There was a problem hiding this comment.
maynot a good idea to cover two types of memory overflow check.
There was a problem hiding this comment.
I will break the common code to separate functions and create two functions for bulk memory and memory check, respectively
lum1n0us
left a comment
lum1n0us
left a comment
There was a problem hiding this comment.
need to fix CI errors.
"""
LLVM ERROR: Instruction Combining did not reach a fixpoint after 1 iterations
"""
The CI issue is due to the update of LLVM, which will be resolved after rebasing the dev branch |
…rflow to accomodate shared heap chain
…chain iteration problem
…hared heap unit test
…and update shared heap unit tests and sample
…arate function for bulk memory and normal memroy 3. static assert 4. add more comments 5. remove unused code
TianlongLiang
force-pushed
the
dev/aot_shared_heap_enhancement
branch
from
b57e280 to
8f49f86
Compare
lum1n0us
merged commit ccdc836
into
bytecodealliance:dev/shared_heap
2 participants
For AOT:
For shared heap tests and samples: