Merge main branch into dev/shared_heap by lum1n0us · Pull Request #4355 · bytecodealliance/wasm-micro-runtime

lum1n0us · 2025-06-11T09:56:41Z

No description provided.

Rust compiler previously deprecated, and now removed the wasm32-wasi target and replaced it with wasm32-wasip1. This change updates all the occurrences of wasm32-wasi in the context of Rust compilation. covers the wasi-nn/test.

- Add AOT module validation to ensure memory constraints are met - Enable AOT validator in build configuration and update related source files

- add default build configuration options and enhance message output for WAMR features - Add Wasm proposal status printing functionality

…ple platforms

…lines

…droid compilation workflow

…permissions

- Enhance wasm mutator fuzz tests by adding export function execution and random value generation - Use --fuel to limit loop size - Use predefined values and enhance argument logging in execution

…es (#4064) fix enlarge 65536 pages conversion overflow in wasm32

#4260)

> **Fix a release-blocking issue** --- Like: ``` vmlib.lib(blocking_op.obj) : error LNK2019: unresolved external symbol __imp_wasm_runtime_begin_blocking_op referenced in function blocking_op_close [D:\a\wasm-micro-runtime\wasm-micro-runtime\wamr-compiler\build\wamrc.vcxproj] vmlib.lib(blocking_op.obj) : error LNK2019: unresolved external symbol __imp_wasm_runtime_end_blocking_op referenced in function blocking_op_close [D:\a\wasm-micro-runtime\wasm-micro-runtime\wamr-compiler\build\wamrc.vcxproj] ```

Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 2.4.1 to 2.4.2. - [Release notes](https://github.com/ossf/scorecard-action/releases) - [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md) - [Commits](ossf/scorecard-action@f49aabe...05b42c6) --- updated-dependencies: - dependency-name: ossf/scorecard-action dependency-version: 2.4.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…4309) it seems meaningless and quite confusing to access a table with two aliases ("lookup" and "backends") within a function. no functional changes are intended.

sync with a more appropriate version of the definitions. as we use the "wasi_ephemeral_nn", which is p1-based, it seems more appropriate to use definitions from witx, not wit. it's a bit unfortunate p2-based wasi-nn made gratuitous changes like this from p1. note: this is an ABI change.

tested with openvino

this would avoid potential issues when multiple instances happen to make an attempt to load a backend at the same time. Fixes: #4314

this would fix undefined symbol errors by making it clear these functions are imported. references: https://github.com/llvm/llvm-project/blob/e2c698c7e836306f1a25c67597ae9e25a1fcc575/llvm/lib/MC/WasmObjectWriter.cpp#L1798-L1799 https://github.com/llvm/llvm-project/blob/e2c698c7e836306f1a25c67597ae9e25a1fcc575/llvm/lib/Object/WasmObjectFile.cpp#L749-L752 https://github.com/llvm/llvm-project/blob/e2c698c7e836306f1a25c67597ae9e25a1fcc575/lld/wasm/Symbols.cpp#L203 https://github.com/llvm/llvm-project/blob/e2c698c7e836306f1a25c67597ae9e25a1fcc575/lld/wasm/Relocations.cpp#L36-L40

+formatting

…4321) By default, zip follows symbolic links and includes the actual files or directories they point to in the archive.

Use a minimum manifest to reduce time consumption

cf. #4324

@WitX

* this enum is (@WitX tag u8) in witx * it seems that some wasm modules actually use non-zero padding and cause errors * it's a bad practice to use C enum for ABI description anyway

Ref: #2465

- wasi_nn.h: make this compatible with wasi_ephemeral_nn cf. #4323 - fix WASM_ENABLE_WASI_EPHEMERAL_NN build this structure is used by host logic as well. ideally definitions for wasm and host should be separated. until it happens, check __wasm__ to avoid the breakage.

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.28.18 to 3.28.19. - [Release notes](https://github.com/github/codeql-action/releases) - [Commits](github/codeql-action@v3.28.18...v3.28.19) --- updated-dependencies: - dependency-name: github/codeql-action dependency-version: 3.28.19 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

github-advanced-security · 2025-06-11T09:56:44Z

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

core/iwasm/interpreter/wasm_interp_fast.c

core/iwasm/interpreter/wasm_loader.c

+ * but if GC is enabled, we need to check the type flag
+ */
+static bool
+check_function_type(const WASMModule *module, uint32 type_index,


core/iwasm/interpreter/wasm_loader.c

 }

+static int
+cmp_v128_const(const void *p_v128_const1, const void *p_v128_const2)


To fix the issue, the unused static function cmp_v128_const should be removed from the file. Additionally, the alert indicates that wasm_loader_prepare_bytecode must also be removed, as it is similarly unused. Care should be taken to ensure that no dependencies or references to these functions exist elsewhere in the file or project.

Steps to implement the fix:

Remove the definition of cmp_v128_const (lines 9644–9651).

Remove the definition of wasm_loader_prepare_bytecode (lines 11262–11281).

Verify that no other code in the file or project depends on these functions.

product-mini/platforms/posix/main.c

 #include "../common/libc_wasi.c"
 #endif

+#include "../common/wasm_proposal.c"


To fix this problem, the code should not include the .c source file directly. Instead, the declarations (function prototypes, types, etc.) from wasm_proposal.c should be moved to a new header file, for example, wasm_proposal.h. The source file wasm_proposal.c should then be compiled separately and linked as part of the build process. In main.c, replace #include "../common/wasm_proposal.c" with #include "../common/wasm_proposal.h". This change should be made only in the code shown (i.e., in main.c), and assumes that the build system will be updated to compile wasm_proposal.c as a separate compilation unit.

.github/workflows/codeql.yml

    # Initializes the CodeQL tools for scanning.
    - name: Initialize CodeQL
-      uses: github/codeql-action/init@v3.28.8
+      uses: github/codeql-action/init@v3.28.19


.github/workflows/codeql.yml

        ./.github/scripts/codeql_buildscript.sh
    - name: Perform CodeQL Analysis
-      uses: github/codeql-action/analyze@v3.28.8
+      uses: github/codeql-action/analyze@v3.28.19


.github/workflows/codeql.yml


    - name: Upload CodeQL results to code scanning
-      uses: github/codeql-action/upload-sarif@v3.28.8
+      uses: github/codeql-action/upload-sarif@v3.28.19


.github/workflows/compilation_on_windows.yml

+            llvm_cache_key: ${{ needs.build_llvm_libraries_on_windows.outputs.cache_key }}
+    steps:
+      - name: checkout
+        uses: actions/checkout@v4


.github/workflows/compilation_on_windows.yml

+      # it is hard to use `format` to assemble the cache key
+      - name: Get LLVM libraries
+        id: retrieve_llvm_libs
+        uses: actions/cache@v4


product-mini/platforms/zephyr/simple/Dockerfile

+
 # hadolint ignore=DL3013
-RUN pip3 install --no-cache-dir west && west init -m https://github.com/zephyrproject-rtos/zephyr --mr v3.5.0 /root/zephyrproject
+RUN pip3 install --no-cache-dir west


product-mini/platforms/zephyr/simple/Dockerfile

-WORKDIR /root
-RUN git clone https://github.com/bytecodealliance/wasm-micro-runtime.git
+WORKDIR /root/zephyrproject/modules/zephyr
+RUN west zephyr-export && pip install --no-cache-dir -r ./scripts/requirements.txt


Georgii Rylov and others added 30 commits January 17, 2025 16:16

Iterate callstack API

68e4534

wamr bool type

d0c6da1

clang-format

1f4d3dd

meaning of the return bool type in the callback

1b82ccc

keep devs notes out of public API

813831d

format

bf6b155

support standard frames as well

c8b8731

format

9ff8052

Calculate func_index instead of adding an extra field to wasm frame

6bfc088

ignore frames with no function

b6daacb

update typo in the comment

5bfbfd5

update signature

478b373

Merge branch 'main' into godjan/iterate_callstack

b9039f9

add correct frame size for aot standard frames

fb6c05e

standard frame is not supported when GC is enabled

f7204bd

add a validator for aot module (#3995)

c6712b4

- Add AOT module validation to ensure memory constraints are met - Enable AOT validator in build configuration and update related source files

Show wasm proposals status during compilation and execution (#3989)

41b2c6d

- add default build configuration options and enhance message output for WAMR features - Add Wasm proposal status printing functionality

initial

67cd504

Add versioning support and update CMake configuration

e64685f

Add versioning information for libraries and executables across multi…

b144e61

…ple platforms

Refactor versioning documentation and adopt semantic versioning guide…

77e8a7d

…lines

Remove deprecated version.h file and update versioning documentation

4f7c5af

Add version.h and update versioning documentation for embedded platforms

10f12c0

Add workflow to confirm version.h is in sync and integrate it into An…

2c2829f

…droid compilation workflow

Cleanup check_version_h workflow by removing unnecessary outputs and …

171d356

…permissions

Merge branch 'main' into godjan/iterate_callstack

267379c

Update memory allocation functions to use allocator user data (#4043)

376385c

[fuzzing] execute every exported function (#3959)

c99ae24

- Enhance wasm mutator fuzz tests by adding export function execution and random value generation - Use --fuel to limit loop size - Use predefined values and enhance argument logging in execution

In wasm32, fix potential conversion overflow when enlarging 65536 pag…

e6a47d5

…es (#4064) fix enlarge 65536 pages conversion overflow in wasm32

lum1n0us and others added 26 commits May 30, 2025 07:42

updating WASI stdio handle initialization and build options for UVWASI (

207da7b

#4260)

Bump version to 2.3.1 and update release notes (#4303)

670aa83

add load_by_name in wasi-nn (#4298)

aa1ff77

Bump uvwasi to latest commit #392e1f1 (#4312)

938503a

wasi_nn_openvino.c: fix a few printf formats (#4310)

1c12a32

wasi-nn: remove "backends" argument from detect_and_load_backend() (#…

16c4675

…4309) it seems meaningless and quite confusing to access a table with two aliases ("lookup" and "backends") within a function. no functional changes are intended.

wasi-nn: fix shared library filenames for macOS (#4306)

61cb972

tested with openvino

wasi_nn_openvino.c: make this buildable (#4305)

6a00874

handle nullable heap reference types in import section (#4302)

93ef19b

wasi-nn: protect the backend lookup table with a lock (#4319)

85efe08

this would avoid potential issues when multiple instances happen to make an attempt to load a backend at the same time. Fixes: #4314

wasi-nn: remove unused wasi_nn_dump_tensor_dimension prototype (#4325)

79cb436

Add wamrc compilation into Windows CI workflow (#4327)

602e86a

+formatting

Update binary compression steps to follow symlinks for actual files (#…

48a9773

…4321) By default, zip follows symbolic links and includes the actual files or directories they point to in the archive.

Update Dockerfile for Zephyr SDK and Zephyr-project versioning (#4335)

97e9502

Use a minimum manifest to reduce time consumption

Collective fix: fix some typos (#4337)

350af77

wasi-nn: move some host-only things out of wasi_nn_types.h (#4334)

769d16e

cf. #4324

wasi-nn: fix the size of tensor->type (#4333)

933f812

* this enum is (@WitX tag u8) in witx * it seems that some wasm modules actually use non-zero padding and cause errors * it's a bad practice to use C enum for ABI description anyway

remove temporary wasi-libc build steps from CI workflows (#4343)

99c75b5

Ref: #2465

wasi-nn: do not assign wasi_nn_ctx->backend multiple times (#4329)

ea5757f

wasi_socket_ext.c: avoid tls to make this library-friendly (#4338)

7f968f5

github-advanced-security bot found potential problems Jun 11, 2025

View reviewed changes

lum1n0us closed this Jun 11, 2025

@@ -9643,10 +9643,3 @@
-            static int
-            cmp_v128_const(const void *p_v128_const1, const void *p_v128_const2)
-            {
-                V128 v128_const1 = *(V128 *)p_v128_const1;
-                V128 v128_const2 = *(V128 *)p_v128_const2;
-                return memcmp(&v128_const1, &v128_const2, sizeof(V128));
-            }
@@ -11261,22 +11254,3 @@
-            static bool
-            wasm_loader_prepare_bytecode(WASMModule *module, WASMFunction *func,
-                                         uint32 cur_func_idx, char *error_buf,
-                                         uint32 error_buf_size)
-            {
-                uint8 *p = func->code, *p_end = func->code + func->code_size, *p_org;
-                uint32 param_count, local_count, global_count;
-                uint8 *param_types, *local_types, local_type, global_type, mem_offset_type,
-                    table_elem_idx_type;
-                BlockType func_block_type;
-                uint16 *local_offsets, local_offset;
-                uint32 type_idx, func_idx, local_idx, global_idx, table_idx;
-                uint32 table_seg_idx, data_seg_idx, count, align, i;
-                mem_offset_t mem_offset;
-                int32 i32_const = 0;
-                int64 i64_const;
-                uint8 opcode;
-                bool return_value = false;
-                WASMLoaderContext *loader_ctx;
-                BranchBlock *frame_csp_tmp;
             #if WASM_ENABLE_GC != 0

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merge main branch into dev/shared_heap#4355

Merge main branch into dev/shared_heap#4355
lum1n0us wants to merge 207 commits intodev/shared_heapfrom
main

lum1n0us commented Jun 11, 2025

Uh oh!

github-advanced-security bot commented Jun 11, 2025

Uh oh!

Uh oh!

Check notice

Copilot Autofix

Check notice

Copilot Autofix

Check notice

Copilot Autofix

Check warning

Check warning

Check warning

Check warning

Check warning

Check warning

Check warning

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

@@ -18,7 +18,7 @@
             #include "../common/libc_wasi.c"
             #endif
-            #include "../common/wasm_proposal.c"
+            #include "../common/wasm_proposal.h"
             #if BH_HAS_DLFCN
             #include <dlfcn.h>

Conversation

lum1n0us commented Jun 11, 2025

Uh oh!

github-advanced-security bot commented Jun 11, 2025

Uh oh!

Uh oh!

Check notice

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot Autofix

Check notice

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot Autofix

Check notice

Copilot Autofix

Check warning

Check warning

Check warning

Check warning

Check warning

Check warning

Check warning

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants