Skip to content

Avoid executable stack by marking that it's not required.#4418

Merged
lum1n0us merged 1 commit intobytecodealliance:mainfrom
jkroonza:noexec_stack
Aug 1, 2025
Merged

Avoid executable stack by marking that it's not required.#4418
lum1n0us merged 1 commit intobytecodealliance:mainfrom
jkroonza:noexec_stack

Conversation

@jkroonza
Copy link
Copy Markdown
Contributor

Also refer to: fluent/fluent-bit#10513

@jkroonza
Copy link
Copy Markdown
Contributor Author

Other assembly files may be affected too, but this is the one that causes problems for me.

@yamt
Copy link
Copy Markdown
Contributor

yamt commented Jun 26, 2025

Other assembly files may be affected too, but this is the one that causes problems for me.

can you consider to apply this to other *.s files?
at least invokeNative_em64_simd.s, which is used by the default configuration for the target.

@jkroonza
Copy link
Copy Markdown
Contributor Author

I can definitely add to all, but I'm not in a position to test all, is that acceptable?

@yamt
Copy link
Copy Markdown
Contributor

yamt commented Jun 26, 2025

I can definitely add to all, but I'm not in a position to test all, is that acceptable?

i think it's fine.

@lum1n0us lum1n0us added the bug-fix Determine if this PR addresses a bug. It will be used by scripts to classify PRs. label Jul 14, 2025
@jkroonza
Copy link
Copy Markdown
Contributor Author

Is there a way to cherry pick this over to 1.3 from here or do I push a separate PR again?

Comment thread core/iwasm/common/arch/invokeNative_osx_universal.s Outdated
Comment thread core/iwasm/common/arch/invokeNative_mingw_x64.s Outdated
Also refer to: fluent/fluent-bit#10513

Signed-off-by: Jaco Kroon <jaco@uls.co.za>
Comment thread core/iwasm/common/arch/fneh.txt
@lum1n0us lum1n0us merged commit 272a41d into bytecodealliance:main Aug 1, 2025
452 checks passed
kr-t pushed a commit to project-ocre/wasm-micro-runtime that referenced this pull request Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug-fix Determine if this PR addresses a bug. It will be used by scripts to classify PRs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants