wasi_nn_llamacpp.c: reject invalid graph and execution context#4422
Merged
lum1n0us merged 1 commit intobytecodealliance:mainfrom Jul 1, 2025
Merged
wasi_nn_llamacpp.c: reject invalid graph and execution context#4422lum1n0us merged 1 commit intobytecodealliance:mainfrom
lum1n0us merged 1 commit intobytecodealliance:mainfrom
Conversation
* return valid graph and execution context instead of using stack garbage. (always 0 for now because we don't implement multiple graph/context for this backend.) * validate user-given graph and execution context values. reject invalid ones.
yamt
requested review from
TianlongLiang,
loganek,
lum1n0us,
no1wudi,
wenyongh and
xujuntwt95329
as code owners
TianlongLiang
approved these changes
Jun 30, 2025
lum1n0us
approved these changes
Jul 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
return valid graph and execution context instead of using stack garbage. (always 0 for now because we don't implement multiple graph/context for this backend.)
validate user-given graph and execution context values. reject invalid ones.