Enable -Wdouble-promotion by default and fix related warnings#4603
Merged
lum1n0us merged 12 commits intobytecodealliance:mainfrom Sep 12, 2025
Merged
Enable -Wdouble-promotion by default and fix related warnings#4603lum1n0us merged 12 commits intobytecodealliance:mainfrom
lum1n0us merged 12 commits intobytecodealliance:mainfrom
Conversation
TianlongLiang
requested review from
loganek,
lum1n0us,
no1wudi,
wenyongh,
xujuntwt95329 and
yamt
as code owners
Contributor
|
Contributor
Author
You are right about NAN., I plan to explicitly convert it like
Yes, I plan to enable -Wdouble-promotion by default, I think it can benefit some embedded platforms. |
Contributor
ok. it makes sense. |
TianlongLiang
force-pushed
the
dev/fix_warning
branch
from
3b2cc71 to
f724bd5
Compare
lum1n0us
added
the
bug-fix
yamt
reviewed
Sep 9, 2025
TianlongLiang
changed the title
TianlongLiang
changed the title
lum1n0us
reviewed
Sep 10, 2025
TianlongLiang
force-pushed
the
dev/fix_warning
branch
from
1fe5e92 to
aa05437
Compare
yamt
approved these changes
Sep 11, 2025
lum1n0us
approved these changes
Sep 12, 2025
kr-t
pushed a commit
to project-ocre/wasm-micro-runtime
that referenced
this pull request
Nov 13, 2025
…dealliance#4603) - fix float to double implicit conversion - add isnanf and signbitf macros, map them to existing double version when float versions are absent - enable -Wdouble-promotion by default - define isnan as macro for platform use core\sahred\platform\common\math.c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.