feat(zephyr): v4.4 migration fixes/improvements#4918
Open
kr-t wants to merge 1 commit intobytecodealliance:mainfrom
Open
feat(zephyr): v4.4 migration fixes/improvements#4918kr-t wants to merge 1 commit intobytecodealliance:mainfrom
kr-t wants to merge 1 commit intobytecodealliance:mainfrom
Conversation
kr-t
requested review from
TianlongLiang,
lum1n0us,
no1wudi and
yamt
as code owners
Zephyr v4.4 has stricter compiler policies. This commit fixes following: - fix implicit casting errors - fix IPV6 related typos/variables/structures - fix zephyr fd relevant implicit casting Signed-off-by: Krisztian Szilvasi <34309983+kr-t@users.noreply.github.com>
Contributor
Author
|
I don't think |
Contributor
Author
|
The nuttx the build seems to fail due to networking issues, not PR-related as well: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR would make WAMR work on Zephyr v4.4, while not breaking anything on previous versions. I have tested this extensively both on v4.3 which we were before, and on new v4.4.
For WAMR, the v4.4 mostly brings stricter policies regarding the compiler and warnings. To make it work and build, fixing some implicit casting was necessary, as well as typos around IPV6 (seems that we never tested it in previous versions, therefore we haven't' noticed those typos).
This commit fixes following:
I remember, that previously we discussed the case for file descriptors, that we shall probably refactor how we use those, instead of moving the zephyr-related header guards from one line to another. While I do agree with this, this change still solves the warning on <=v4,3 and error on v4.4, while isn't further increasing any complexity.
Please let me know, if you want me to make some further tests or changes. I have found a zephyr-related misinformation as well, which I reported here: #4913 ; but that is irrelevant to this PR's goal.