Skip to content

Commit 29888ca

Browse files
committed
address CI issues
Signed-off-by: Joel Dice <joel.dice@fermyon.com>
1 parent 3f5fb97 commit 29888ca

4 files changed

Lines changed: 9 additions & 4 deletions

File tree

Cargo.toml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,9 @@ unstable_features = 'warn'
5252
unused_import_braces = 'warn'
5353
unused-lifetimes = 'warn'
5454
unused-macro-rules = 'warn'
55+
# TODO: address the warnings and remove this line:
56+
mismatched_lifetime_syntaxes = 'allow'
57+
5558

5659
# Lints that are part of the `rust-2024-compatibility` group. This group is a
5760
# bit too noisy to enable wholesale but some selective items are ones we want to

crates/wasm-wave/Cargo.toml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,9 @@ categories = ["wasm", "encoding", "parser-implementations"]
1111
repository = "https://github.com/bytecodealliance/wasm-tools/tree/main/crates/wasm-wave"
1212
readme = "README.md"
1313

14+
[lints]
15+
workspace = true
16+
1417
[features]
1518
default = ["wit"]
1619
wit = ["dep:wit-parser"]

crates/wasm-wave/tests/ui.rs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ use std::{collections::HashMap, fmt::Write, fs, path::Path, sync::OnceLock};
44
use wasm_wave::{
55
parser::ParserError,
66
untyped::UntypedFuncCall,
7-
value::{resolve_wit_func_type, FuncType, Value},
7+
value::{FuncType, Value, resolve_wit_func_type},
88
wasm::{DisplayValue, WasmFunc},
99
};
1010
use wit_parser::Resolve;
@@ -109,8 +109,7 @@ fn ui() -> Result<()> {
109109
.with_context(|| format!("failed to read {expected:?}"))?;
110110
assert_eq!(
111111
expected, actual,
112-
"expectation `{}` did not match actual `{}`",
113-
expected, actual,
112+
"expectation `{expected}` did not match actual `{actual}`",
114113
);
115114
}
116115
}

crates/wasmparser/src/validator/component.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1758,7 +1758,7 @@ impl ComponentState {
17581758
.check_core_type(
17591759
types,
17601760
FuncType::new(
1761-
iter::repeat_n(ValType::I32, if elem_ty.is_some() { 2 } else { 1 }),
1761+
iter::repeat(ValType::I32).take(if elem_ty.is_some() { 2 } else { 1 }),
17621762
[ValType::I32],
17631763
),
17641764
offset,

0 commit comments

Comments
 (0)