Remove some #![expect(clippy::allow_attributes_without_reason)] (#10661)

Clean up some crates by migrating from `#[allow]` to `#[expect]`
(ideally) or `#[allow]`-with-reason

Author: alexcrichton

cranelift/interpreter/src/lib.rs

@@ -2,8 +2,6 @@
 //!
 //! This module is a project for interpreting Cranelift IR.
 
-#![expect(clippy::allow_attributes_without_reason, reason = "crate not migrated")]
-
 pub mod address;
 pub mod environment;
 pub mod frame;

cranelift/interpreter/src/step.rs

@@ -59,7 +59,6 @@ fn collect_block_args(
 /// Interpret a single Cranelift instruction. Note that program traps and interpreter errors are
 /// distinct: a program trap results in `Ok(Flow::Trap(...))` whereas an interpretation error (e.g.
 /// the types of two values are incompatible) results in `Err(...)`.
-#[allow(unused_variables)]
 pub fn step<'a, I>(state: &mut dyn State<'a>, inst_context: I) -> Result<ControlFlow<'a>, StepError>
 where
     I: InstructionContext,
@@ -123,7 +122,7 @@ where
                 match mask.len() {
                     16 => DataValue::V128(mask.try_into().expect("a 16-byte vector mask")),
                     8 => DataValue::V64(mask.try_into().expect("an 8-byte vector mask")),
-                    length => panic!("unexpected Shuffle mask length {}", mask.len()),
+                    length => panic!("unexpected Shuffle mask length {length}"),
                 }
             }
             // 8-bit.
@@ -259,6 +258,7 @@ where
     };
 
     // Based on `condition`, indicate where to continue the control flow.
+    #[expect(unused_variables, reason = "here in case it's needed in the future")]
     let branch_when = |condition: bool, block| -> Result<ControlFlow, StepError> {
         if condition {
             continue_at(block)

cranelift/interpreter/src/value.rs

@@ -1,7 +1,7 @@
 //! The [DataValueExt] trait is an extension trait for [DataValue]. It provides a lot of functions
 //! used by the rest of the interpreter.
 
-#![allow(trivial_numeric_casts)]
+#![expect(trivial_numeric_casts, reason = "macro-generated code")]
 
 use core::fmt::{self, Display, Formatter};
 use core::ops::Neg;

cranelift/isle/isle/src/ast.rs

@@ -1,6 +1,6 @@
 //! Abstract syntax tree (AST) created from parsed ISLE.
 
-#![allow(missing_docs)]
+#![expect(missing_docs, reason = "fields mostly self-describing")]
 
 use crate::lexer::Pos;
 use crate::log;

cranelift/isle/isle/src/files.rs

@@ -1,4 +1,4 @@
-#![allow(missing_docs)]
+#![expect(missing_docs, reason = "fields mostly self-describing")]
 
 use crate::codegen::Prefix;
 use std::ops::Index;

cranelift/isle/isle/src/lib.rs

@@ -1,6 +1,5 @@
 #![doc = include_str!("../README.md")]
 #![deny(missing_docs)]
-#![expect(clippy::allow_attributes_without_reason, reason = "crate not migrated")]
 
 macro_rules! declare_id {
     (

crates/fiber/src/lib.rs

@@ -1,4 +1,3 @@
-#![expect(clippy::allow_attributes, reason = "crate not migrated yet")]
 #![no_std]
 
 #[cfg(any(feature = "std", unix, windows))]

crates/wasi-common/src/lib.rs

@@ -69,7 +69,6 @@
 
 #![warn(clippy::cast_sign_loss)]
 #![cfg_attr(docsrs, feature(doc_cfg))]
-#![expect(clippy::allow_attributes_without_reason, reason = "crate not migrated")]
 
 pub mod clocks;
 mod ctx;

crates/wasi-common/src/pipe.rs

@@ -1,5 +1,3 @@
-// This is mostly stubs
-#![allow(unused_variables, dead_code)]
 //! Virtual pipes.
 //!
 //! These types provide easy implementations of `WasiFile` that mimic much of the behavior of Unix

crates/wasi-common/src/snapshots/preview_1/error.rs

@@ -124,9 +124,9 @@ fn from_raw_os_error(err: Option<i32>) -> Option<Error> {
         RustixErrno::TIMEDOUT => Errno::Timedout.into(),
 
         // On some platforms.into(), these have the same value as other errno values.
-        #[allow(unreachable_patterns)]
+        #[allow(unreachable_patterns, reason = "see comment")]
         RustixErrno::WOULDBLOCK => Errno::Again.into(),
-        #[allow(unreachable_patterns)]
+        #[allow(unreachable_patterns, reason = "see comment")]
         RustixErrno::OPNOTSUPP => Errno::Notsup.into(),
 
         _ => return None,