fix: add defer pinner.Unpin() (#1613)

* fix: add defer pinner.Unpin()

Signed-off-by: Andrew Steurer <94206073+asteurer@users.noreply.github.com>

* feat: add test

Signed-off-by: Andrew Steurer <94206073+asteurer@users.noreply.github.com>

---------

Signed-off-by: Andrew Steurer <94206073+asteurer@users.noreply.github.com>

Author: asteurer

crates/go/src/lib.rs

@@ -1326,7 +1326,10 @@ func {camel}({go_params}) {go_results} {{
 
             (
                 if abi::guest_export_needs_post_return(resolve, func) {
-                    format!("{PINNER} := &runtime.Pinner{{}}")
+                    format!(
+                        "{PINNER} := &runtime.Pinner{{}}
+                    defer {PINNER}.Unpin()"
+                    )
                 } else {
                     String::new()
                 },

tests/runtime-async/async/return-string/runner.go

@@ -0,0 +1,35 @@
+//@ wasmtime-flags = '-Wcomponent-model-async'
+
+package export_wit_world
+
+import (
+	"fmt"
+	"runtime"
+
+	test "wit_component/my_test_i"
+)
+
+/*
+
+This tests for pinner leaks in generated Go code for async exported
+function that return heap-allocated types (strings, lists, etc.). Without
+`pinner.Unpin()`, the `runtime.Pinner` object goes out of scope after
+the function returns with pinned pointers still alive. When GC finalizes
+the Pinner, it panics:
+
+```
+panic: runtime error: runtime.Pinner: found leaking pinned pointer;
+forgot to call Unpin()?
+```
+*/
+
+func Run() {
+	// Perform a heap allocation
+	got := test.ReturnString()
+	if got != "hello" {
+		panic(fmt.Sprintf("expected \"hello\", got %q", got))
+	}
+
+	// Force GC to finalize any leaked Pinners
+	runtime.GC()
+}

tests/runtime-async/async/return-string/test.go

@@ -0,0 +1,5 @@
+package export_my_test_i
+
+func ReturnString() string {
+	return "hello"
+}

tests/runtime-async/async/return-string/test.wit

@@ -0,0 +1,14 @@
+package my:test;
+
+interface i {
+  return-string: async func() -> string;
+}
+
+world test {
+  export i;
+}
+
+world runner {
+  import i;
+  export run: async func();
+}