Implement async task cancellation #1264
Merged
Merged
Conversation
alexcrichton
force-pushed
the
async-cancel
branch
from
d34b1ac to
c6684aa
Compare
alexcrichton
force-pushed
the
async-cancel
branch
from
c6684aa to
65c99db
Compare
alexcrichton
changed the title
Member
Author
|
Ok with tests I think this is now good to go. I've |
alexcrichton
force-pushed
the
async-cancel
branch
from
65c99db to
bcea359
Compare
dicej
approved these changes
Apr 30, 2025
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
This commit implements async task cancellation in Rust for subtasks created through imported calls. This involved some extra bindings-related code to drop both lists and owned handles (effectively a full destructor) along with some refactorings of how waitables are handled due to new states that can pop up.
alexcrichton
force-pushed
the
async-cancel
branch
from
bcea359 to
3411b64
Compare
Merged
via the queue into
bytecodealliance:main
with commit Apr 30, 2025
16ad298
18 of 19 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit implements async task cancellation in Rust for subtasks
created through imported calls. This involved some extra
bindings-related code to drop both lists and owned handles (effectively
a full destructor) along with some refactorings of how waitables are
handled due to new states that can pop up.