Refactor how guest exported tasks work#1268
Merged
alexcrichton merged 2 commits intoApr 10, 2025
Merged
Conversation
This commit refactors some of the code generation and ABI instructions used for exported tasks. Instead of a future + closure they're represented now only as a single future which internally handles the invocation of `task.return`. No major functional change here, just some refactoring.
dicej
approved these changes
Apr 10, 2025
Collaborator
dicej
left a comment
dicej
left a comment
There was a problem hiding this comment.
LGTM, assuming the wasip3-prototyping tests pass.
| if needs_cleanup_list { | ||
| let vec = self.path_to_vec(); | ||
| uwriteln!(self.src, "let mut cleanup_list = {vec}::new();"); | ||
| uwriteln!(self.src, "let mut cleanup_list = Vec::new();"); |
Collaborator
There was a problem hiding this comment.
Why do we not need to use self.path_to_vec() here?
Member
Author
There was a problem hiding this comment.
Oh this is my mistake, we do still need that and this just got lost in some refactorings I made along the way and didn't double-check the diff at the end.
alexcrichton
added a commit
to alexcrichton/wasip3-prototyping
that referenced
this pull request
Apr 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit refactors some of the code generation and ABI instructions used for exported tasks. Instead of a future + closure they're represented now only as a single future which internally handles the invocation of
task.return. No major functional change here, just some refactoring.