Change how async stream/future results are encoded#1273
Merged
alexcrichton merged 1 commit intoApr 15, 2025
Merged
Conversation
alexcrichton
added a commit
to alexcrichton/wasip3-prototyping
that referenced
this pull request
Apr 15, 2025
Updating to WebAssembly/component-model#498, will require bytecodealliance/wit-bindgen#1273
alexcrichton
commented
Apr 15, 2025
| ReturnCode::Cancelled(0) => Ok((StreamResult::Cancelled, buf)), | ||
|
|
||
| amt => { | ||
| ReturnCode::Completed(amt) | ReturnCode::Closed(amt) | ReturnCode::Cancelled(amt) => { |
Member
Author
There was a problem hiding this comment.
I'll note that for now I've opted to just lose information for here as it's in theory harmless. For example if a stream is closed after transferring N items then future writes should in theory not even hit the host and immediately say "nope it's close", or perhaps the state is reflected in the return value where the stream is consumed. I don't think it's super important to expose these states just yet so I've left that for a future update.
dicej
approved these changes
Apr 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating to WebAssembly/component-model#498