fix(moonbit): Update keywords#1282
Merged
Merged
Conversation
Contributor
|
Hi,
You can remove 'expect', but not 'main' nor 'init'.
A function named 'init' is considered the initialization process of that package, and a function named 'main' is considered the entrance when that package is made an executable.
…________________________________
发件人: Mendy Berger ***@***.***>
发送时间: 2025年4月25日 21:00
收件人: bytecodealliance/wit-bindgen ***@***.***>
抄送: Zihang Ye ***@***.***>; Mention ***@***.***>
主题: [bytecodealliance/wit-bindgen] fix(moonbit): Update keywords (PR #1282)
Keyword list taken from https://github.com/moonbitlang/moonbit-compiler/blob/main/src/lex_keyword_tbl.ml
I removed expect, main, and init, as they're not listed as reserved in the compiler.
@peter-jerry-ye<https://github.com/peter-jerry-ye> can you confirm that it's safe to remove them?
Keeping this draft until that's confirmed.
________________________________
You can view, comment on, or merge this pull request online at:
#1282
Commit Summary
* 377c0d8<377c0d8> fix(moonbit): Update keywords
File Changes
(1 file<https://github.com/bytecodealliance/wit-bindgen/pull/1282/files>)
* M crates/moonbit/src/lib.rs<https://github.com/bytecodealliance/wit-bindgen/pull/1282/files#diff-2ba6ef40c887d0d1c8a36fe05bae58a5e2cbd2e25bb7c388a1e4a5575213e1c6> (15)
Patch Links:
* https://github.com/bytecodealliance/wit-bindgen/pull/1282.patch
* https://github.com/bytecodealliance/wit-bindgen/pull/1282.diff
―
Reply to this email directly, view it on GitHub<#1282>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AD7U6XKOY64MZFCMRJ45N2T23IWYTAVCNFSM6AAAAAB33SSDH6VHI2DSMVQWIX3LMV43ASLTON2WKOZTGAZDAMBQGAYTMMI>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Contributor
Author
|
Thanks @peter-jerry-ye! |
peter-jerry-ye
approved these changes
Apr 28, 2025
alexcrichton
approved these changes
Apr 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keyword list taken from https://github.com/moonbitlang/moonbit-compiler/blob/main/src/lex_keyword_tbl.ml
I removed
expect,main, andinit, as they're not listed as reserved in the compiler.@peter-jerry-ye can you confirm that it's safe to remove them?
Keeping this draft until that's confirmed.