Conditionally use wac or wasm-compose for wit-bindgen test#1285
Merged
Conversation
While `wac` is being merged upstream into `wasm-tools` fall back to using `wasm-compose` when `wac` is not otherwise necessary. This ensures that there's a composition tool used which is at the same version as all the other wasm-tools tools which `wac` doesn't guarantee just yet.
dicej
approved these changes
Apr 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While
wacis being merged upstream intowasm-toolsfall back to usingwasm-composewhenwacis not otherwise necessary. This ensures that there's a composition tool used which is at the same version as all the other wasm-tools tools whichwacdoesn't guarantee just yet.