Add some more async tests#1287
Merged
alexcrichton merged 4 commits intoApr 30, 2025
Merged
Conversation
I went through various parts of the guest runtime and sprinkled
`if true { panic!() }` throughout. Anything that wasn't hit got a test.
This led to a few issues in wasip3-prototyping:
* bytecodealliance/wasip3-prototyping#137
* bytecodealliance/wasip3-prototyping#138
* bytecodealliance/wasip3-prototyping#139
* bytecodealliance/wasip3-prototyping#140
so not all tests are fully enabled yet but they should get enabled as
bugs get fixed.
Additionally this starts to use `CALLBACK_CODE_YIELD`. That's disabled
for callbacks due to bytecodealliance/wasip3-prototyping#140 but it's
enabled for `block_on` where it translates to a `waitable-set.poll`
instead of a `waitable-set.wait`.
dicej
approved these changes
Apr 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I went through various parts of the guest runtime and sprinkled
if true { panic!() }throughout. Anything that wasn't hit got a test. This led to a few issues in wasip3-prototyping:waitable-set.pollmismatched with the spec wasip3-prototyping#139CALLBACK_CODE_YIELDwasip3-prototyping#140so not all tests are fully enabled yet but they should get enabled as bugs get fixed.
Additionally this starts to use
CALLBACK_CODE_YIELD. That's disabled for callbacks due to bytecodealliance/wasip3-prototyping#140 but it's enabled forblock_onwhere it translates to awaitable-set.pollinstead of awaitable-set.wait.