Skip to content

chore: remove send-future #1253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rvolosatovs merged 1 commit into from
May 27, 2026
Merged

chore: remove send-future #1253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,6 @@ redis = { version = "1.2", default-features = false }
reqwest = { version = "0.13", default-features = false }
rustls = { version = "0.23", default-features = false }
semver = { version = "1", default-features = false }
send-future = { version = "0.1", default-features = false }
serde = { version = "1", default-features = false }
serde_json = { version = "1", default-features = false }
syn = { version = "2", default-features = false, features = ["printing"] }
Expand Down
1 change: 0 additions & 1 deletion crates/transport/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ anyhow = { workspace = true, features = ["std"] }
bytes = { workspace = true }
futures = { workspace = true, features = ["std"] }
pin-project-lite = { workspace = true }
send-future = { workspace = true }
tokio = { workspace = true, features = ["macros", "rt", "time"] }
tokio-stream = { workspace = true }
tokio-util = { workspace = true, features = ["codec", "io"] }
Expand Down
40 changes: 0 additions & 40 deletions crates/transport/src/invoke.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,44 +27,6 @@ pub trait Invoke: Send + Sync {
type Incoming: AsyncRead + Index<Self::Incoming> + Send + Sync + Unpin + 'static;

/// Invoke function `func` on instance `instance`
///
/// Note, that compilation of code calling methods on [`Invoke`] implementations within [`Send`] async functions
/// may fail with hard-to-debug errors due to a compiler bug:
/// [https://github.com/rust-lang/rust/issues/96865](https://github.com/rust-lang/rust/issues/96865)
///
/// The following fails to compile with rustc 1.78.0:
///
/// ```compile_fail
/// use core::future::Future;
///
/// fn invoke_send<T>() -> impl Future<Output = anyhow::Result<(T::Outgoing, T::Incoming)>> + Send
/// where
/// T: wrpc_transport::Invoke<Context = ()> + Default,
/// {
/// async { T::default().invoke((), "compiler-bug", "free", "since".into(), [[Some(2024)].as_slice(); 0]).await }
/// }
/// ```
///
/// ```text
/// async { T::default().invoke((), "compiler-bug", "free", "since".into(), [[Some(2024)].as_slice(); 0]).await }
/// | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ implementation of `AsRef` is not general enough
/// |
/// = note: `[&'0 [Option<usize>]; 0]` must implement `AsRef<[&'1 [Option<usize>]]>`, for any two lifetimes `'0` and `'1`...
/// = note: ...but it actually implements `AsRef<[&[Option<usize>]]>`
/// ```
///
/// The fix is to call [`send`](send_future::SendFuture::send) provided by [`send_future::SendFuture`], re-exported by this crate, on the future before awaiting:
/// ```
/// use core::future::Future;
/// use wrpc_transport::SendFuture as _;
///
/// fn invoke_send<T>() -> impl Future<Output = anyhow::Result<(T::Outgoing, T::Incoming)>> + Send
/// where
/// T: wrpc_transport::Invoke<Context = ()> + Default,
/// {
/// async { T::default().invoke((), "compiler-bug", "free", "since".into(), [[Some(2024)].as_slice(); 0]).send().await }
/// }
/// ```
fn invoke<P>(
&self,
cx: Self::Context,
Expand Down Expand Up @@ -331,7 +293,6 @@ mod tests {

use bytes::Bytes;
use futures::{Stream, StreamExt as _};
use send_future::SendFuture as _;

use super::*;

Expand All @@ -354,7 +315,6 @@ mod tests {
(),
[[None].as_slice()],
)
.send()
.await?;
Ok(r0)
}
Expand Down
1 change: 0 additions & 1 deletion crates/transport/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ pub use frame::{
Accept, Decoder as FrameDecoder, Encoder as FrameEncoder, Frame, FrameRef, Server,
};
pub use invoke::{Invoke, InvokeExt};
pub use send_future::SendFuture;
pub use serve::{Serve, ServeExt};
pub use value::*;

Expand Down
8 changes: 4 additions & 4 deletions crates/wit-bindgen-rust/src/interface.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -629,7 +629,7 @@ pub fn serve_interface<'a, T: {wrpc_transport}::Serve>(
self.src,
r#"
let wrpc__ = {anyhow}::Context::context(
{wrpc_transport}::SendFuture::send({wrpc_transport}::InvokeExt::invoke_values_blocking(wrpc__, cx__, "{instance}", "{}", ({params}), "#,
{wrpc_transport}::InvokeExt::invoke_values_blocking(wrpc__, cx__, "{instance}", "{}", ({params}), "#,
rpc_func_name(func),
wrpc_transport = self.gen.wrpc_transport_path(),
params = {
Expand All @@ -650,7 +650,7 @@ pub fn serve_interface<'a, T: {wrpc_transport}::Serve>(
self.src.push_str(".as_slice(), ");
}
}
self.src.push_str("])).await,\n");
self.src.push_str("]).await,\n");
uwriteln!(
self.src,
r#"
Expand All @@ -666,7 +666,7 @@ pub fn serve_interface<'a, T: {wrpc_transport}::Serve>(
self.src,
r#"
let (wrpc__, io__) = {anyhow}::Context::context(
{wrpc_transport}::SendFuture::send({wrpc_transport}::InvokeExt::invoke_values(wrpc__, cx__, "{instance}", "{}", ({params}), "#,
{wrpc_transport}::InvokeExt::invoke_values(wrpc__, cx__, "{instance}", "{}", ({params}), "#,
rpc_func_name(func),
wrpc_transport = self.gen.wrpc_transport_path(),
params = {
Expand All @@ -687,7 +687,7 @@ pub fn serve_interface<'a, T: {wrpc_transport}::Serve>(
self.src.push_str(".as_slice(), ");
}
}
self.src.push_str("])).await,\n");
self.src.push_str("]).await,\n");
uwriteln!(
self.src,
r#"
Expand Down
Loading