hotspot: support hotspot17 gtest#128
Merged
luchsh merged 1 commit intojdk17u-target8from Apr 30, 2026
Merged
Conversation
K0u1e
force-pushed
the
dev/run_hotspot_gtest
branch
2 times, most recently
from
cd48bc5 to
e42439b
Compare
K0u1e
force-pushed
the
dev/run_hotspot_gtest
branch
2 times, most recently
from
dc4cb74 to
9ac679d
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
K0u1e
force-pushed
the
dev/run_hotspot_gtest
branch
5 times, most recently
from
bbf6231 to
ad56349
Compare
K0u1e
force-pushed
the
dev/run_hotspot_gtest
branch
3 times, most recently
from
0b48fc5 to
a2c101e
Compare
luchsh
reviewed
Apr 28, 2026
| { \ | ||
| if [[ ! -f $(HOTSPOT_GTEST_BUILD_DIR)/spec.gmk ]] || \ | ||
| ! grep -Fqx 'GTEST_FRAMEWORK_SRC := $(GTEST_DIR)' $(HOTSPOT_GTEST_BUILD_DIR)/spec.gmk 2>/dev/null; then \ | ||
| bash configure --with-debug-level=$(MODE) \ |
Collaborator
There was a problem hiding this comment.
can we merge L297~L308 with L273~L284 to avoid copying large chunk of code?
luchsh
reviewed
Apr 28, 2026
duanyangjing
approved these changes
Apr 29, 2026
K0u1e
force-pushed
the
dev/run_hotspot_gtest
branch
from
a2c101e to
236eb49
Compare
K0u1e
force-pushed
the
dev/run_hotspot_gtest
branch
from
236eb49 to
1b12155
Compare
Collaborator
|
rename |
K0u1e
changed the title
luchsh
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
support hotspot gtest and enable gtest on CI.