fix(browser-operator): use model-specified scroll amount instead of hard-coded 500#1830
Open
Br1an67 wants to merge 1 commit into
Open
fix(browser-operator): use model-specified scroll amount instead of hard-coded 500#1830Br1an67 wants to merge 1 commit into
Br1an67 wants to merge 1 commit into
Conversation
Use the amount parameter from model output (e.g., scroll(direction='down', amount=200)) instead of hard-coding 500px. Falls back to 500px when no amount is specified. Also add support for left/right scroll directions. Closes bytedance#903
✅ Deploy Preview for agent-tars-docs canceled.
|
✅ Deploy Preview for tarko canceled.
|
14 tasks
Contributor
Author
|
Hi — just a gentle bump on this. Happy to make any changes if needed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #903
The
handleScrollmethod inbrowser-operator.tshard-codedscrollAmount = 500, ignoring theamountparameter from the model output (e.g.scroll(direction='down', amount=200)). The action parser correctly extractsamountintoinputs.amount, but it was never used.Changes:
inputs.amount(with fallback to 500) for scroll distanceleftandrightscroll directions (previously onlyup/downwere handled)Checklist