Skip to content

feat(skills): add vefaas-cli#221

Open
songhn233 wants to merge 1 commit into
mainfrom
feat/add-vefaas-cli
Open

feat(skills): add vefaas-cli#221
songhn233 wants to merge 1 commit into
mainfrom
feat/add-vefaas-cli

Conversation

@songhn233
Copy link
Copy Markdown
Collaborator

Change-Id: Ia56a8fc7b0c15b951e35434df52fd06d9a8c5160

Change-Id: Ia56a8fc7b0c15b951e35434df52fd06d9a8c5160
Copy link
Copy Markdown

@JiwaniZakir JiwaniZakir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a typo in cookbooks/manage-functions.md line 4: "vefaas CLI installe" is missing the trailing d.

The deploy command pattern used throughout (--gatewayName $(vefaas run listgateways --first)) silently substitutes an empty string if no gateways are available, which would cause a confusing deployment failure. The docs should call out this failure mode and suggest verifying the output of vefaas run listgateways --first before piping it into deploy.

The .env.prod example in deploy-existing-code.md mixes quoted and unquoted values (PGPASSWORD=secret vs API_KEY="your-api-key"), which could mislead users about whether quoting is required — worth making the example consistent.

The SSO login step in SKILL.md notes it "opens browser, auto-completes when authorized" but the skill also claims to support CI/CD scenarios. There's no guidance on what happens in headless environments where a browser can't open — the AK/SK path should be mentioned as the fallback explicitly in that context rather than just listed in the table without cross-referencing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants