Skip to content
This repository was archived by the owner on Jan 12, 2026. It is now read-only.

Commit 87e5e04

Browse files
committed
to #103, pruned test cases for Kafka PB format
1 parent bc60582 commit 87e5e04

7 files changed

Lines changed: 62 additions & 1002 deletions

File tree

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<project xmlns="http://maven.apache.org/POM/4.0.0"
3+
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
4+
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
5+
<parent>
6+
<artifactId>bitsail-component-formats</artifactId>
7+
<groupId>com.bytedance.bitsail</groupId>
8+
<version>${revision}</version>
9+
</parent>
10+
<modelVersion>4.0.0</modelVersion>
11+
12+
<artifactId>bitsail-component-format-pb</artifactId>
13+
14+
<properties>
15+
<maven.compiler.source>8</maven.compiler.source>
16+
<maven.compiler.target>8</maven.compiler.target>
17+
</properties>
18+
19+
</project>

bitsail-components/bitsail-component-formats/pom.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@
3232
<packaging>pom</packaging>
3333
<modules>
3434
<module>bitsail-component-format-json</module>
35+
<module>bitsail-component-format-pb</module>
3536
</modules>
3637

3738
<dependencies>

bitsail-connectors/bitsail-connectors-legacy/bitsail-connector-kafka/src/main/java/com/bytedance/bitsail/connector/legacy/kafka/deserialization/DeserializationSchemaFactory.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ public static KafkaDeserializationSchema<Row> getDeserializationSchema(BitSailCo
6767

6868
if (StringUtils.equalsIgnoreCase(PB_DESERIALIZATION_SCHEMA_KEY, formatType)) {
6969
try {
70-
return new PbKafkaDeserializationSchema(configuration);
70+
return new CountKafkaDeserializationSchemaWrapper<>(configuration, new PbDeserializationSchema(configuration));
7171
} catch (Exception e) {
7272
throw new IllegalArgumentException("Pb parser encountered error during initialization.", e);
7373
}

bitsail-connectors/bitsail-connectors-legacy/bitsail-connector-kafka/src/main/java/com/bytedance/bitsail/connector/legacy/kafka/deserialization/PbKafkaDeserializationSchema.java renamed to bitsail-connectors/bitsail-connectors-legacy/bitsail-connector-kafka/src/main/java/com/bytedance/bitsail/connector/legacy/kafka/deserialization/PbDeserializationSchema.java

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -26,21 +26,20 @@
2626
import org.apache.flink.api.common.serialization.DeserializationSchema;
2727
import org.apache.flink.api.common.typeinfo.TypeInformation;
2828
import org.apache.flink.api.java.typeutils.RowTypeInfo;
29-
import org.apache.flink.streaming.connectors.kafka.KafkaDeserializationSchema;
3029
import org.apache.flink.types.Row;
3130
import org.apache.flink.util.Collector;
32-
import org.apache.kafka.clients.consumer.ConsumerRecord;
3331

32+
import java.io.IOException;
3433
import java.util.List;
3534

3635
@Internal
37-
public class PbKafkaDeserializationSchema implements KafkaDeserializationSchema<Row> {
36+
public class PbDeserializationSchema implements DeserializationSchema<Row> {
3837
private static final long serialVersionUID = -2556547991095476394L;
3938
private final PbBytesParser parser;
4039
private final RowTypeInfo rowTypeInfo;
4140
private final int arity;
4241

43-
public PbKafkaDeserializationSchema(BitSailConfiguration jobConf) throws Exception {
42+
public PbDeserializationSchema(BitSailConfiguration jobConf) throws Exception {
4443
this.parser = new PbBytesParser(jobConf);
4544

4645
List<Descriptors.FieldDescriptor> fields = parser.getDescriptor().getFields();
@@ -77,23 +76,21 @@ private PrimitiveColumnTypeInfo<?> getColumnTypeInfo(Descriptors.FieldDescriptor
7776

7877
@Override
7978
public void open(DeserializationSchema.InitializationContext context) throws Exception {
80-
KafkaDeserializationSchema.super.open(context);
8179
}
8280

8381
@Override
84-
public boolean isEndOfStream(Row row) {
85-
return false;
82+
public Row deserialize(byte[] value) throws IOException {
83+
return this.parser.parse(new Row(arity), value, 0, value.length, null, rowTypeInfo);
8684
}
8785

8886
@Override
89-
public Row deserialize(ConsumerRecord<byte[], byte[]> record) throws Exception {
90-
byte[] value = record.value();
91-
return this.parser.parse(new Row(arity), value, 0, value.length, null, rowTypeInfo);
87+
public void deserialize(byte[] value, Collector<Row> out) throws IOException {
88+
out.collect(deserialize(value));
9289
}
9390

9491
@Override
95-
public void deserialize(ConsumerRecord<byte[], byte[]> message, Collector<Row> out) throws Exception {
96-
out.collect(deserialize(message));
92+
public boolean isEndOfStream(Row row) {
93+
return false;
9794
}
9895

9996
@Override

0 commit comments

Comments
 (0)