fix(channels): handle bot p2p chat entered event in Feishu channel#1830
Open
lysandre001 wants to merge 1 commit into
Open
fix(channels): handle bot p2p chat entered event in Feishu channel#1830lysandre001 wants to merge 1 commit into
lysandre001 wants to merge 1 commit into
Conversation
- Register handler for im.chat.access_event.bot_p2p_chat_entered_v1 event to prevent 'processor not found' errors when users enter bot private chat - Remove redundant None check in FeishuChannel.send() error handling The lark-oapi SDK sends a bot_p2p_chat_entered_v1 event when a user first opens a private chat with the bot. Without a registered handler, this caused an error log on every bot entry. Added a no-op handler that logs the event.
|
yilin seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Collaborator
|
@lysandre001 Thanks for your contribution. Please sign the CLA by clicking the CLA assistant button before we start to review the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
im.chat.access_event.bot_p2p_chat_entered_v1event to prevent "processor not found" errors when users first open a private chat with the Feishu botNonecheck inFeishuChannel.send()error handling that was unreachableProblem
When a user enters a bot's private chat in Feishu, the Feishu platform sends a
bot_p2p_chat_entered_v1event via the WebSocket connection. Since this event was not registered in theEventDispatcherHandler, the lark-oapi SDK logged an error on every bot entry:Fix
Added
register_p2_im_chat_access_event_bot_p2p_chat_entered_v1(self._on_bot_chat_entered)to the event handler builder chain, with a simple logging handler that acknowledges the event without side effects.Changes
backend/app/channels/feishu.pybot_p2p_chat_entered_v1event handler + cleanup unreachable None check in send error pathTesting
processor not founderrorsFeishu channel startedandChannelService started with channels: ['feishu']in gateway logs