fix: [#102] Fix configuration priority order to match documentation#391
Open
nandanosql wants to merge 1 commit into
Open
fix: [#102] Fix configuration priority order to match documentation#391nandanosql wants to merge 1 commit into
nandanosql wants to merge 1 commit into
Conversation
…ntation The resolve_config_value function was checking ENV before Config, but the README documents the priority as: CLI > Configuration file > Environment variables > Default values This commit reorders the checks to match the documented priority: CLI > Config > ENV > Default
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #102
Problem
The
resolve_config_valuefunction inconfig.pyhad conflicting priority definitions:This caused confusion and unexpected behavior where environment variables would override values in the config file, contrary to what users would expect from reading the docs.
Solution
Reordered the priority checks in
resolve_config_valueto match the documented priority:The docstring was also updated to reflect the correct priority.