fix: escape path in find command to prevent shell injection#402
Open
hobostay wants to merge 1 commit into
Open
fix: escape path in find command to prevent shell injection#402hobostay wants to merge 1 commit into
hobostay wants to merge 1 commit into
Conversation
The `find` command in `_view()` passes the `path` parameter directly to a shell via `asyncio.create_subprocess_shell`. A path containing shell metacharacters (e.g., `/tmp/repo; rm -rf /`) could lead to command injection. Use `shlex.quote()` to properly escape the path. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
Test User seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
edit_tool.py:162where thepathparameter is passed unsanitized to afindshell commandProblem
In
TextEditorTool._view(), when viewing a directory, the path is interpolated directly into a shell command:The
run()function usesasyncio.create_subprocess_shell(), so a path containing shell metacharacters could execute arbitrary commands.Fix
Use
shlex.quote()to properly escape the path before passing it to the shell command.Test plan
🤖 Generated with Claude Code