Fixing picking behaviour for multiple cameras#108
Open
schecko wants to merge 1 commit into
Open
Conversation
…ra to perform picking with
|
I also ran into this issue while using a 3d world camera, and a 2d camera for a GUI overlay. I came up with what i think is a fix prior to noticing this PR (see above). It may be worth testing/comparing the solutions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change, the picking system would pick the first camera in the query (Entity, &Camera, &GlobalTransform, &OrthographicProjection). This means there isn't any way to match the picking camera chosen with the camera used in viewport calculations. This matters for projects that use multiple Orthographic cameras, particularly with different transformations. An example use case is a game that might used a fixed camera for the UI(lunex) and a dynamic camera for gameplay. Changing the gameplay camera transform will invalidate the picking raycasts, causing the UI to render correctly but not be interactive or have incorrect hit boxes.