Skip to content

Commit f77f9a4

Browse files
Fix crash in selectionBox when gltf-model loads after entity is detached (#72)
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent dc8d3e9 commit f77f9a4

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

src/lib/viewport.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,9 +162,10 @@ export function Viewport(inspector) {
162162
} else if (object.el.hasAttribute('gltf-model')) {
163163
const listener = (event) => {
164164
if (event.target !== object.el) return; // we got an event for a child, ignore
165+
object.el.removeEventListener('model-loaded', listener);
166+
if (object.parent === null) return; // entity was detached before model loaded
165167
selectionBox.setFromObject(object);
166168
selectionBox.visible = true;
167-
object.el.removeEventListener('model-loaded', listener);
168169
};
169170
object.el.addEventListener('model-loaded', listener);
170171
}

0 commit comments

Comments
 (0)