Add CTD thermal lag correction, YAML constants reader, and GSW salini…#234
Add CTD thermal lag correction, YAML constants reader, and GSW salini…#234lauryntalbot wants to merge 8 commits into
Conversation
jklymak
left a comment
jklymak
left a comment
There was a problem hiding this comment.
Ideally this would have some documentation and an example as part of pyglider. As it is, it's a bit mysterious. Bonus points if you have a test.
| @@ -0,0 +1,6 @@ | |||
| { | |||
| @@ -0,0 +1,118 @@ | |||
| # PyGlider: Adjust CTD variables | |||
There was a problem hiding this comment.
This needs to be incorporated in the rest of the docs somehow.
|
This is going to have a doc warning because your new markdown is not in a table of contents anywhere. Please add to the |
| Vertical grid spacing in meters. Ignored if ``depth_bins`` is not None | ||
| Vertical grid spacing in meters. | ||
|
|
||
| maskfunction : callable or None, optional |
There was a problem hiding this comment.
This is in the other PR. Why is it here?
| accuracy = None, | ||
| maskfunction = None, | ||
| interp_variables = None): | ||
|
|
| return interp | ||
|
|
||
| def correct_sal(ds, fn, alpha, tau, interpolate_filter = None): | ||
| """ |
|
|
||
|
|
||
| def CPROOF_sal_interpolate_filter(ds): | ||
| """ |
There was a problem hiding this comment.
The function name is "sal" but then talks about temperature.
This should also be moved to utils
|
|
||
|
|
||
| def get_conductivity_clean(ts0, dT, dz, flag_stdev, clean_stdev, accuracy=None): | ||
|
|
There was a problem hiding this comment.
remove extra carriage return.
This is a bit vague about what actually gets returned here. "flagged" is vague. You create a new variable in the time series "conductivity_QC" and set to 1 or four, right?
| ts['temperature_QC'] =(('time'), np.ones_like(ts.temperature) ) | ||
|
|
||
| #added to C-PROOF files for gridding function | ||
| vars_ = ['conductivity_QC','salinity_QC','temperature_QC'] |
There was a problem hiding this comment.
When do these originally get added?
| ts['salinity_adjusted'] = sal_adj | ||
|
|
||
| ############# Update metadata | ||
| ts.attrs['processing_details'] = 'Processing details are located on the C-PROOF website for this mission under the reports tab.' |
There was a problem hiding this comment.
You can't have all this c-proof stuff injected here. pyglider is for everyone, not just C-PROOF. These things should be handled in the yaml.
2 participants
…ty updates