Ignore 'Valid'. There's no like-for-like

Author: c0ntax

src/Factory/ConstraintFactory.php

@@ -29,18 +29,21 @@ class ConstraintFactory
     /**
      * @param Constraint    $validationConstraint
      * @param FormInterface $form
-     * @return ConstraintInterface
+     * @return ConstraintInterface|null
      * @throws \Exception
      * @throws \InvalidArgumentException
      * @throws \RuntimeException
      */
     public static function createFromValidationConstraint(
         Constraint $validationConstraint,
         FormInterface $form
-    ): ConstraintInterface {
+    ): ?ConstraintInterface {
         // TODO Change this to use the ViewInterface instead of the FormInterface as that makes a lot more sense!
 
-        if ($validationConstraint instanceof \Symfony\Component\Validator\Constraints\NotNull) {
+        if ($validationConstraint instanceof  \Symfony\Component\Validator\Constraints\Valid) {
+            // This case is not an error. There just isn't a 'like-for-like' replacement
+            return null;
+        } elseif ($validationConstraint instanceof \Symfony\Component\Validator\Constraints\NotNull) {
             return new Required($validationConstraint->message);
         } elseif ($validationConstraint instanceof \Symfony\Component\Validator\Constraints\NotBlank) {
             return new Required($validationConstraint->message);

src/Form/Extension/ParsleyTypeExtension.php

@@ -100,7 +100,10 @@ private function createParsleyConstraintsFromValidationConstraints(
         $out = [];
         foreach ($validationConstraints as $validationConstraint) {
             try {
-                $out[] = ConstraintFactory::createFromValidationConstraint($validationConstraint, $form);
+                $parsleyConstraint = ConstraintFactory::createFromValidationConstraint($validationConstraint, $form);
+                if ($parsleyConstraint !== null) {
+                    $out[] = $parsleyConstraint;
+                }
             } catch (\RuntimeException $exception) {
                 // Don't care for now!
                 // TODO How loud this should be should be configurable

tests/Factory/ConstraintFactoryTest.php

@@ -23,6 +23,7 @@
 use Symfony\Component\Validator\Constraints\NotBlank;
 use Symfony\Component\Validator\Constraints\NotNull;
 use Symfony\Component\Validator\Constraints\Regex;
+use Symfony\Component\Validator\Constraints\Valid;
 use Symfony\Component\Validator\ConstraintViolationList;
 use Symfony\Component\Validator\Mapping\ClassMetadata;
 use Symfony\Component\Validator\Validator\ValidatorInterface;
@@ -66,6 +67,12 @@ public function getFactoryTestData()
         $form = $factory->create(TestType::class, null, []);
 
         return [
+            [
+                new Valid(),
+                $form->get('id'),
+                null,
+                'Valid to Null',
+            ],
             [
                 new NotNull(['message' => 'Give me something']),
                 $form->get('id'),