Skip to content

fix: code updates, lints and git hooks#2

Open
bongx00 wants to merge 19 commits into
c0rnf13ld:masterfrom
bongx00:master
Open

fix: code updates, lints and git hooks#2
bongx00 wants to merge 19 commits into
c0rnf13ld:masterfrom
bongx00:master

Conversation

@bongx00

@bongx00 bongx00 commented Jun 2, 2026

Copy link
Copy Markdown

Hi @c0rnf13ld , first of all, thanks for open-sourcing your project, It's really cool. That being said, I made a few changes aimed at improving the code and simplifying usage:

  1. Remove sudo: sudo is required to test whether the target is up because of the use of python-nmap. When we use the tool It means that the target is already up, removing the python-nmap -sU check eliminates the need to run the script with sudo. Any errors are handled by ipmitool as usual.

  2. IPMI as dependency: With the nmap part removed, adding ipmitool installation instructions to the README removes the need for apt-get install steps. Then, Python dependencies can then be moved fully into requirements.txt, resulting in a cleaner separation of concerns.

  3. Collaboration (GitHub Actions & linters): I added some linting rules for code quality and commit style consistency. I believe this improves maintainability. The GitHub Actions workflow is triggered once the files are added to the repository, and the linting dependencies are defined in requirements-dev.txt, specifically for development purposes. This means it does not affect users who simply want to clone and run the project.

  4. Do not stop on first valid user: I implemented a change to address an issue raised in the project. It now allows dumping all hashes when a user wordlist is provided, instead of stopping at the first valid match (removing early break behavior).

  5. Removal of the Bash version: I removed the Bash implementation and its associated files. Maintaining both Bash and Python versions introduced unnecessary duplication, while the Bash version was also noisier and slower. Keeping Python as the sole implementation provides a cleaner codebase, reduces maintenance overhead, and establishes a single, consistent execution path.

Kind regards!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant