fix: Smart/Origin: no maximum number of transfers by default

[lgourdin]

this PR fixes bug n°1786 (on S/O ticket platform)

Summary by CodeRabbit

• Bug Fixes
  • Transfer limit setting is now consistently applied across all trip searches, including extended timeframe queries.
  • When the transfer limit toggle is off, searches correctly run with no cap on transfers.
  • Prevents cases where the max transfers preference was ignored or inconsistently handled.

[coderabbitai]

Walkthrough

Introduced a computed property maxNbTransfers in PlanATripSection.vue and updated two API request payloads to send max_nb_transfers using this value instead of maxTransfers.

Changes

Cohort / File(s)	Summary
Trip planning logic and API payloads src/views/document/utils/boxes/PlanATripSection.vue	Added computed maxNbTransfers returning maxTransfers when limitTransfers is true, else -1. Replaced payload fields to use max_nb_transfers: this.maxNbTransfers in outbound and extended timeframe journey requests.

Sequence Diagram(s)

sequenceDiagram
  participant U as User
  participant C as PlanATripSection (Vue)
  participant API as Journey API

  U->>C: Configure trip (limitTransfers, maxTransfers)
  C->>C: Compute maxNbTransfers = limitTransfers ? maxTransfers : -1
  C->>API: Request outbound journey<br/>with payload { max_nb_transfers: maxNbTransfers }
  API-->>C: Outbound results

  Note over C: For extended timeframe
  C->>API: Request extended timeframe<br/>with { max_nb_transfers: maxNbTransfers }
  API-->>C: Extended results

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I twitch my ears at transfer counts,
Hop-hop, the logic cleanly mounts.
If limits set, we send the max—
Else −1 guides our API tracks.
Carrots packed, requests in pairs,
I bound through routes without despairs. 🥕🚆

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title succinctly summarizes the primary bug fix by indicating that, in the Smart Origin feature, there will be no maximum number of transfers by default, which directly reflects the addition of the maxNbTransfers computed property returning -1 when transfers are unlimited and the corresponding API payload updates. It is clear, specific, and focused on the key change without extraneous detail.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch smart-origin/fix_max_nb_transfers

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d1b029b and 700d034.

📒 Files selected for processing (1)

• src/views/document/utils/boxes/PlanATripSection.vue (3 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: build (lts/*)

🔇 Additional comments (3)

src/views/document/utils/boxes/PlanATripSection.vue (3)

755-759: LGTM! Clean fix for the transfer limit bug.

The computed property correctly returns -1 (no limit) when limitTransfers is false, and the actual maxTransfers value when the user opts to limit connections. This addresses the bug where users would unintentionally be limited to 0 transfers (direct routes only) by default.

---

943-956: Correct usage of the new computed property.

The outbound journey request now properly uses maxNbTransfers, which will send -1 when no transfer limit is set, allowing the API to return routes with any number of connections.

---

992-1010: Consistent application of the fix in extended timeframe request.

The fallback journey request also correctly uses maxNbTransfers, ensuring consistent behavior when searching for the last journey of the day.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}