Skip to content

fix: absence of search_lang param in search#4567

Merged
eddy-geek merged 1 commit into
masterfrom
search_lang
Jul 1, 2026
Merged

fix: absence of search_lang param in search#4567
eddy-geek merged 1 commit into
masterfrom
search_lang

Conversation

@eddy-geek

@eddy-geek eddy-geek commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

it helps the elasticsearch to match documents in the user's current language

Summary by CodeRabbit

  • Bug Fixes
    • Improved document search results by sending the current language context with search requests.
  • Refactor
    • Updated a search call to a clearer multi-line format without changing behavior.

@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

This PR reformats a c2c.search call in AssociationsWindow.vue into multi-line style without behavior changes, and extends the search payload in InputDocument.vue with l and pl language parameters derived from the current language.

Changes

c2c.search call updates

Layer / File(s) Summary
Search call formatting and language parameters
src/components/association-editor/AssociationsWindow.vue, src/components/generics/inputs/InputDocument.vue
AssociationsWindow.vue's search call is reformatted to multi-line style with no logic change; InputDocument.vue's loadOptions() adds l and pl parameters from this.$language.current to the c2c.search payload.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Poem

A hop, a tweak, a line rewrapped,
Two little params neatly slapped,
Language now rides with the search,
No logic lost, just tidy perch,
Thump thump — ship it, rabbit's clapped! 🐇

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title matches the main intent: adding missing language-related search parameters to search requests.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch search_lang

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

…lasticsearch to match documents in the user's current language
@eddy-geek eddy-geek changed the title Fix absence of search_lang param in search fix: absence of search_lang param in search Jul 1, 2026
@github-actions github-actions Bot added the bug Something isn't working label Jul 1, 2026
@eddy-geek eddy-geek merged commit 0de4980 into master Jul 1, 2026
9 checks passed
@eddy-geek eddy-geek deleted the search_lang branch July 1, 2026 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants