Add morphological_graphs() and improve error handling for GeometryCollection #179
Merged
Merged
Conversation
morphological_graphs() and improve error handling for morphological_graphs() and improve error handling for GeometryCollection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds
morphological_graphs(), a new public API for generating morphological graphs for multiple network-distance budgets in one call.Previously, callers that needed graphs for several distances had to call
morphological_graph()repeatedly. That repeated expensive shared work, especially reachability computation and enclosed tessellation generation. The new implementation prepares the morphology context once, builds the shared reachability field once, creates tessellation context from the largest requested distance, and then applies per-distance filtering to produce each graph.The change also refactors
morphological_graph()to use the same shared preparation and per-distance graph-building path, keeping the single-distance API behavior aligned with the new multi-distance API. As part of this refactor, fixed internal ID column constants are introduced for place and movement layers.This PR also improves tessellation robustness by converting
GeometryCollectiontessellation cells to their polygonal parts where possible, and dropping empty or non-polygonal cells before downstream processing.Related Issues
N/A
Checklist