Fix enclosed tessellation recovery for numerically degenerate Voronoi partitions#180
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the retry order for
momepy.enclosed_tessellationfailures so thatTypeErrorfrom boundary simplification first retries withgrid_size=1e-3, before falling back tosimplify=False. The coarser grid size repairs the underlying partition in the observed real-data failure case, whilesimplify=Falsecan allow degenerate overlapping cells to pass through.It also adds validation for overfilled enclosures after tessellation generation. For each enclosure, the total cell area is checked against
enclosure_area * 1.05. If cells exceed that tolerance, the tessellation is treated as degenerate:grid_size=1e-3when the caller has not pinnedgrid_sizeRegression coverage was added for:
TypeErrorretrying withgrid_size=1e-3simplify=Falsewhen the grid-size retry still failsRelated Issues
N/A
Checklist