Fix gabriel_graph#183
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes the Gabriel graph edge filtering logic in
city2graph.proximity.gabriel_graph.Previously, the implementation tested whether points fell inside the disc with diameter
uvby computing distances from each point to the midpoint of the candidate edge. With large projected-coordinate values, this midpoint/radius comparison could become numerically fragile and incorrectly drop valid Gabriel edges.The fix replaces that predicate with an equivalent dot-product test:
(u, v)iffdot(u - w, v - w) < 0The docstring was also updated to describe the open-disc definition explicitly.
A regression test was added using large projected-CRS-like coordinates. The test verifies that:
gabriel_graphmatches a brute-force Gabriel graph definitionMST ⊆ RNG ⊆ Gabriel ⊆ DelaunayRelated Issues
N/A
Checklist